[bug #68091] Inefficient Integer Data Loading from MAT-Files

Rik <[email protected]> Mon, 27 Apr 2026 08:12:52 -0400 (EDT)

Newsgroups	gmane.comp.gnu.octave.bugs
Message-ID	<[email protected]>

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Follow-up Comment #15, bug #68091 (group octave):

Also, I removed what should be dead code in cset f882315af4e4.

changeset:   35771:f882315af4e4
tag:         tip
user:        Rik <[email protected]>
date:        Mon Apr 27 14:10:26 2026 +0200
files:       libinterp/corefcn/ls-mat5.cc
description:
maint: Remove dead code in ls-mat5.cc (bug #68091)

* ls-mat5.cc (read_mat5_integer_data (std::istream&, int *): Remove template
specialization for "int".  Matlab integers in files, and Octave integer
arrays,
require a specific size such as "uint8".


diff --git a/libinterp/corefcn/ls-mat5.cc b/libinterp/corefcn/ls-mat5.cc
--- a/libinterp/corefcn/ls-mat5.cc
+++ b/libinterp/corefcn/ls-mat5.cc
@@ -376,11 +376,6 @@ read_mat5_integer_data (std::istream& is
                         octave_idx_type count, bool swap,
                         mat5_data_type type);
 
-template void
-read_mat5_integer_data (std::istream& is, int *m,
-                        octave_idx_type count, bool swap,
-                        mat5_data_type type);
-
 #define OCTAVE_MAT5_INTEGER_READ(TYP)                                   \
   {                                                                     \
     TYP re (dims);                                                      \





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68091>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc (application/pgp-signature, 228 B)