[bug #68091] Inefficient Integer Data Loading from MAT-Files

Rik <[email protected]> Mon, 27 Apr 2026 11:01:00 -0400 (EDT)

Newsgroups	gmane.comp.gnu.octave.bugs
Message-ID	<[email protected]>

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Follow-up Comment #17, bug #68091 (group octave):


[comment #14 comment #14:]
> One potential problem with the code / mat-5 format is that int8NDArray stores
> octave_int8, while MAT data is int8_t so std::is_same_v<StorageT, T> is false
> and it still takes the temp-buffer plus element-wise assignment path.
> 

Yes, this is a problem.  I ran under gdb and for *uint8* the template is
called as


read_mat5_integer_data_storage<unsigned char, octave_int<unsigned char> >


So this line of code

if constexpr (std::is_same_v<storageT, T>)

needs to be changed to use the template parameter that *octave_int* was
created with.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68091>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc (application/pgp-signature, 228 B)