[bug #68448] replace strtoull/strtoul with from_char in lex.ll

Markus Mützel <[email protected]> Sun, 14 Jun 2026 05:57:53 -0400 (EDT)

Newsgroups	gmane.comp.gnu.octave.bugs
Message-ID	<[email protected]>

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Update of bug #68448 (group octave):

                  Status:                    None => Need Info
         Planned Release:                    None => 12.1.0 (current default)

    _______________________________________________________

Follow-up Comment #1:

Looks good to me. 👍

But don't we need the fallback to fast_float here, too. E.g., in
`oct-string.cc`, we have:

#if defined (OCTAVE_HAVE_STD_FROM_CHARS_DOUBLE)
  auto [ptr, ec] = std::from_chars (first, last, num);
#elif defined (OCTAVE_HAVE_FAST_FLOAT)
  auto [ptr, ec] = fast_float::from_chars (first, last, num);
#else
#  error "Cannot convert string to floating-point number.  This should be
unreachable."
#endif


Could you please attach a patch with commit message for this change?



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68448>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc (application/pgp-signature, 228 B)