bug#16134: [PATCH 3/3] libparted:tests: Enable _implemented_disk_label for atari

Phil Susi <[email protected]>
Newsgroups gmane.comp.gnu.parted.bugs
Message-ID <aaab11f7-c9cb-b181-57d7-ef71ba632340__13755.8926865042$1492528095$gmane$org@ubuntu.com>
If the actual test fails when ss != 512, we probably shouldn't bother
calling it in the first place.  In other words, swap the order of
get_sector_size() != 512 and the test, and change from != to ==.

Also Sebastian had a point about the main partition table commit lacking
a full message.  Could you make these corrections and repost the full
series?  Also add a NEWS entry describing the new feature.

On 10/16/2016 6:19 AM, John Paul Adrian Glaubitz wrote:
> Use get_sector_size() to ensure we're testing on 512-byte
> sectors only.
> 
> Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
> ---
>  libparted/tests/common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libparted/tests/common.c b/libparted/tests/common.c
> index 8ef3915..2be0e3a 100644
> --- a/libparted/tests/common.c
> +++ b/libparted/tests/common.c
> @@ -82,7 +82,9 @@ _implemented_disk_label (const char *label)
>  {
>          /* FIXME: these have minor problems, so skip them, temporarily.  */
>          if (STREQ (label, "amiga")) return 0;
> -        if (STREQ (label, "atari")) return 0;
> +
> +        if (STREQ (label, "atari") && get_sector_size() != 512)
> +                return 0;
>  
>          /* Not implemented yet */
>          if (STREQ (label, "aix")) return 0;
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.