gprolog not respecting LDFLAGS

Keri Harris <[email protected]> Sat, 10 Jul 2021 12:50:11 +0200
Newsgroups	gmane.comp.gnu.prolog.bugs
Message-ID	<[email protected]>
--=-53JYAr6q1u1vXmkN7Rq8
Content-Type: multipart/alternative; boundary="=-MopIPI57OIEROpgIlt/0"


--=-MopIPI57OIEROpgIlt/0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi

When building gprolog-1.5.0 a number of binaries are linked without
respecting LDFLAGS:


x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts  -o pl_config pl_config.c


x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts -o gplc top_comp.c -lm






x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts  -o cpp_headers cpp_headers.c



x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts -o hexgplc hexfilter.c



x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts -o wam2ma wam2ma.o wam_parser.o


x86_64-pc-linux-gnu-gcc  -O2 -pipe -frecord-gcc-switches -fcommon -fno-
strict-aliasing -Wno-char-subscripts -o ma2asm ma2asm.o ma2asm_inst.o
ma_parser.o




The binaries above in src/EnginePl are missing LDFLAGS due to a typo in
the Makefile (LFLAGS vs LDFLAGS); the other binaries are missing
LDFLAGS in the $CC invocation.

Attached is a patch that I've been using on Gentoo Linux.


Thanks

Keri

--=-MopIPI57OIEROpgIlt/0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<html dir=3D"ltr"><head></head><body style=3D"text-align:left; direction:lt=
r;"><div>Hi</div><div><br></div><div>When building gprolog-1.5.0 a number o=
f binaries are linked without respecting LDFLAGS:</div><div><br></div><div>=
<br></div><div><font face=3D"monospace" size=3D"3"></font><span style=3D"fo=
nt-family: monospace; font-size: medium;">x86_64-pc-linux-gnu-gcc &nbsp;-O2=
 -pipe -frecord-gcc-switches -fcommon -fno-strict-aliasing -Wno-char-subscr=
ipts&nbsp;&nbsp;-o pl_config pl_config.c</span></div><div><span style=3D"fo=
nt-family: monospace; font-size: medium;"><br></span></div><div><span style=
=3D"font-family: monospace; font-size: medium;">x86_64-pc-linux-gnu-gcc &nb=
sp;-O2 -pipe -frecord-gcc-switches -fcommon -fno-strict-aliasing -Wno-char-=
subscripts -o gplc top_comp.c -lm</span></div><div></div><div></div><div></=
div><div></div><div><span style=3D"font-family: monospace; font-size: mediu=
m;"><br></span></div><div><span style=3D"font-family: monospace; font-size:=
 medium;">x86_64-pc-linux-gnu-gcc &nbsp;-O2 -pipe -frecord-gcc-switches -fc=
ommon -fno-strict-aliasing -Wno-char-subscripts&nbsp;&nbsp;-o cpp_headers c=
pp_headers.c</span></div><div></div><div><span style=3D"font-family: monosp=
ace; font-size: medium;"><br></span></div><div><span style=3D"font-family: =
monospace; font-size: medium;">x86_64-pc-linux-gnu-gcc &nbsp;-O2 -pipe -fre=
cord-gcc-switches -fcommon -fno-strict-aliasing -Wno-char-subscripts -o hex=
gplc hexfilter.c</span></div><div></div><div><span style=3D"font-family: mo=
nospace; font-size: medium;"><br></span></div><div><span style=3D"font-fami=
ly: monospace; font-size: medium;">x86_64-pc-linux-gnu-gcc &nbsp;-O2 -pipe =
-frecord-gcc-switches -fcommon -fno-strict-aliasing -Wno-char-subscripts -o=
 wam2ma wam2ma.o wam_parser.o</span></div><div><span style=3D"font-family: =
monospace; font-size: medium;"><br></span></div><div><span style=3D"font-fa=
mily: monospace; font-size: medium;">x86_64-pc-linux-gnu-gcc &nbsp;-O2 -pip=
e -frecord-gcc-switches -fcommon -fno-strict-aliasing -Wno-char-subscripts =
-o ma2asm ma2asm.o ma2asm_inst.o ma_parser.o</span></div><div><span style=
=3D"font-family: monospace; font-size: medium;"><br></span></div><div><span=
 style=3D"font-family: monospace; font-size: medium;"><br></span></div><div=
>The binaries above in src/EnginePl are missing LDFLAGS due to a typo in th=
e Makefile (LFLAGS vs LDFLAGS); the other binaries are missing LDFLAGS in t=
he $CC invocation.</div><div><br></div><div>Attached is a patch that I've b=
een using on Gentoo Linux.</div><div><br></div><div><br></div><div>Thanks</=
div><div><br></div><div>Keri</div></body></html>

--=-MopIPI57OIEROpgIlt/0--

--=-53JYAr6q1u1vXmkN7Rq8
Content-Disposition: attachment; filename="gprolog-1.5.0-ldflags.patch"
Content-Type: text/x-patch; name="gprolog-1.5.0-ldflags.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

ZGlmZiAtdXIgZ3Byb2xvZy0xLjUuMC5vcmlnL3NyYy9FbmdpbmVQbC9NYWtlZmlsZS5pbiBncHJv
bG9nLTEuNS4wL3NyYy9FbmdpbmVQbC9NYWtlZmlsZS5pbgotLS0gZ3Byb2xvZy0xLjUuMC5vcmln
L3NyYy9FbmdpbmVQbC9NYWtlZmlsZS5pbgkyMDIxLTA3LTEwIDEwOjEzOjIzLjA0NjU2NDQ3MiAt
MDAwMAorKysgZ3Byb2xvZy0xLjUuMC9zcmMvRW5naW5lUGwvTWFrZWZpbGUuaW4JMjAyMS0wNy0x
MCAxMDo0MTo1OS41ODU0OTI2ODEgLTAwMDAKQEAgLTIsNiArMiw3IEBACiBHUExDICAgICAgICAg
ID0gQEdQTENACiBDQyAgICAgICAgICAgID0gQENDQCBAQ0ZMQUdTX01BQ0hJTkVACiBDRkxBR1Mg
ICAgICAgID0gQENGTEFHU0AKK0xERkxBR1MgICAgICAgPSBATERGTEFHU0AKIEFSX1JDICAgICAg
ICAgPSBAQVJfUkNACiBSQU5MSUIgICAgICAgID0gQFJBTkxJQkAKIApAQCAtMzUsNyArMzYsNyBA
QAogY29uZmlnOiBwbF9jb25maWdARVhFX1NVRkZJWEAgd2FtX3JlZ3MuaAogCiBwbF9jb25maWdA
RVhFX1NVRkZJWEA6IHBsX2NvbmZpZy5jIGdwX2NvbmZpZy5oIG1hY2hpbmUuaCBzdGFja3Nfc2ln
c2Vndi5oIHdhbV9hcmNoaS5kZWYKLQkkKENDKSAkKENGTEFHUykgJChMRkxBR1MpIEBDQ19FWEVf
TkFNRV9PUFRAcGxfY29uZmlnQEVYRV9TVUZGSVhAIHBsX2NvbmZpZy5jCisJJChDQykgJChDRkxB
R1MpICQoTERGTEFHUykgQENDX0VYRV9OQU1FX09QVEBwbF9jb25maWdARVhFX1NVRkZJWEAgcGxf
Y29uZmlnLmMKIAogCiB3YW1fcmVncy5oOiBwbF9jb25maWdARVhFX1NVRkZJWEAgbWFjaGluZS5o
IHN0YWNrc19zaWdzZWd2Lmggd2FtX2FyY2hpLmRlZgpAQCAtNDksMTAgKzUwLDEwIEBACiAKIAog
Y3BwX2hlYWRlcnNARVhFX1NVRkZJWEA6IGNwcF9oZWFkZXJzLmMKLQkkKENDKSAkKENGTEFHUykg
JChMRkxBR1MpIEBDQ19FWEVfTkFNRV9PUFRAY3BwX2hlYWRlcnNARVhFX1NVRkZJWEAgY3BwX2hl
YWRlcnMuYworCSQoQ0MpICQoQ0ZMQUdTKSAkKExERkxBR1MpIEBDQ19FWEVfTkFNRV9PUFRAY3Bw
X2hlYWRlcnNARVhFX1NVRkZJWEAgY3BwX2hlYWRlcnMuYwogCiB0cnlfc2lnYWN0aW9uQEVYRV9T
VUZGSVhAOiB0cnlfc2lnYWN0aW9uLmMKLQkkKENDKSAkKENGTEFHUykgJChMRkxBR1MpIEBDQ19F
WEVfTkFNRV9PUFRAdHJ5X3NpZ2FjdGlvbkBFWEVfU1VGRklYQCB0cnlfc2lnYWN0aW9uLmMKKwkk
KENDKSAkKENGTEFHUykgJChMREZMQUdTKSBAQ0NfRVhFX05BTUVfT1BUQHRyeV9zaWdhY3Rpb25A
RVhFX1NVRkZJWEAgdHJ5X3NpZ2FjdGlvbi5jCiAKIAogCmRpZmYgLXVyIGdwcm9sb2ctMS41LjAu
b3JpZy9zcmMvTWEyQXNtL01ha2VmaWxlLmluIGdwcm9sb2ctMS41LjAvc3JjL01hMkFzbS9NYWtl
ZmlsZS5pbgotLS0gZ3Byb2xvZy0xLjUuMC5vcmlnL3NyYy9NYTJBc20vTWFrZWZpbGUuaW4JMjAy
MS0wNy0wNyAxMDoxMzowMi4wMDAwMDAwMDAgLTAwMDAKKysrIGdwcm9sb2ctMS41LjAvc3JjL01h
MkFzbS9NYWtlZmlsZS5pbgkyMDIxLTA3LTEwIDEwOjQwOjIyLjY4MzQ5NjczNCAtMDAwMApAQCAt
MSw3ICsxLDggQEAKLUdQTEMgICA9IEBHUExDQAotQ0MgICAgID0gQENDQCBAQ0ZMQUdTX01BQ0hJ
TkVACi1DRkxBR1MgPSBAQ0ZMQUdTQAotTERMSUJTID0gQExETElCU0AKK0dQTEMgICAgPSBAR1BM
Q0AKK0NDICAgICAgPSBAQ0NAIEBDRkxBR1NfTUFDSElORUAKK0NGTEFHUyAgPSBAQ0ZMQUdTQAor
TERGTEFHUyA9IEBMREZMQUdTQAorTERMSUJTICA9IEBMRExJQlNACiAKICMgc2V0IGJ5IG1hcHBl
cnMuc2gKIEZPUkNFX01BUCA9CkBAIC0yNSw3ICsyNiw3IEBACiAKIG1hMmFzbUBFWEVfU1VGRklY
QDogbWEyYXNtQE9CSl9TVUZGSVhAIG1hX3BhcnNlckBPQkpfU1VGRklYQCBcCiAgICAgICAgICAg
ICAgICAgICAgIG1hMmFzbV9pbnN0QE9CSl9TVUZGSVhAIG1hMmFzbV9pbnN0LmMKLQkkKENDKSAk
KENGTEFHUykgQENDX0VYRV9OQU1FX09QVEBtYTJhc21ARVhFX1NVRkZJWEAgbWEyYXNtQE9CSl9T
VUZGSVhAIG1hMmFzbV9pbnN0QE9CSl9TVUZGSVhAIG1hX3BhcnNlckBPQkpfU1VGRklYQAorCSQo
Q0MpICQoTERGTEFHUykgQENDX0VYRV9OQU1FX09QVEBtYTJhc21ARVhFX1NVRkZJWEAgbWEyYXNt
QE9CSl9TVUZGSVhAIG1hMmFzbV9pbnN0QE9CSl9TVUZGSVhAIG1hX3BhcnNlckBPQkpfU1VGRklY
QAogCiAKIGNsZWFuOgpkaWZmIC11ciBncHJvbG9nLTEuNS4wLm9yaWcvc3JjL1RvcENvbXAvTWFr
ZWZpbGUuaW4gZ3Byb2xvZy0xLjUuMC9zcmMvVG9wQ29tcC9NYWtlZmlsZS5pbgotLS0gZ3Byb2xv
Zy0xLjUuMC5vcmlnL3NyYy9Ub3BDb21wL01ha2VmaWxlLmluCTIwMjEtMDctMDcgMTA6MTM6MDIu
MDAwMDAwMDAwIC0wMDAwCisrKyBncHJvbG9nLTEuNS4wL3NyYy9Ub3BDb21wL01ha2VmaWxlLmlu
CTIwMjEtMDctMTAgMTA6NDE6MzEuMDgxNDkzODczIC0wMDAwCkBAIC00LDcgKzQsNyBAQAogQ0ZM
QUdTICAgICAgICAgID0gQENGTEFHU0AKIEhFWEdQTEMgICAgICAgICA9IEBIRVhHUExDQAogQ0Mg
ICAgICAgICAgICAgID0gQENDQCBAQ0ZMQUdTX01BQ0hJTkVACi1DRkxBR1MgICAgICAgICAgPSBA
Q0ZMQUdTQAorTERGTEFHUyAgICAgICAgID0gQExERkxBR1NACiBMRExJQlMgICAgICAgICAgPSBA
TERMSUJTQAogVE9QX0xFVkVMX0xJQlMgID0gQFRPUF9MRVZFTF9MSUJTQAogCkBAIC0yNCwxMCAr
MjQsMTAgQEAKIAogJChHUExDKUBFWEVfU1VGRklYQDogdG9wX2NvbXAuYyBjb3B5aW5nLmMgLi4v
RW5naW5lUGwvd2FtX3JlZ3MuaCBcCiAgICAgICAgICAuLi9FbmdpbmVQbC9ncF9jb25maWcuaCAu
Li9FbmdpbmVQbC9tYWNoaW5lMS5jIGRlY29kZV9oZXhhLmMgY29weWluZy5jIHByb2xvZ19wYXRo
LmMKLQkkKENDKSAkKENGTEFHUykgQENDX0VYRV9OQU1FX09QVEAkKEdQTEMpQEVYRV9TVUZGSVhA
IHRvcF9jb21wLmMgJChMRExJQlMpCisJJChDQykgJChDRkxBR1MpICQoTERGTEFHUykgQENDX0VY
RV9OQU1FX09QVEAkKEdQTEMpQEVYRV9TVUZGSVhAIHRvcF9jb21wLmMgJChMRExJQlMpCiAKICQo
SEVYR1BMQylARVhFX1NVRkZJWEA6IGhleGZpbHRlci5jIGRlY29kZV9oZXhhLmMKLQkkKENDKSAk
KENGTEFHUykgQENDX0VYRV9OQU1FX09QVEAkKEhFWEdQTEMpQEVYRV9TVUZGSVhAIGhleGZpbHRl
ci5jCisJJChDQykgJChDRkxBR1MpICQoTERGTEFHUykgQENDX0VYRV9OQU1FX09QVEAkKEhFWEdQ
TEMpQEVYRV9TVUZGSVhAIGhleGZpbHRlci5jCiAKIAogCmRpZmYgLXVyIGdwcm9sb2ctMS41LjAu
b3JpZy9zcmMvV2FtMk1hL01ha2VmaWxlLmluIGdwcm9sb2ctMS41LjAvc3JjL1dhbTJNYS9NYWtl
ZmlsZS5pbgotLS0gZ3Byb2xvZy0xLjUuMC5vcmlnL3NyYy9XYW0yTWEvTWFrZWZpbGUuaW4JMjAy
MS0wNS0wMyAxMzo1NTozNC4wMDAwMDAwMDAgLTAwMDAKKysrIGdwcm9sb2ctMS41LjAvc3JjL1dh
bTJNYS9NYWtlZmlsZS5pbgkyMDIxLTA3LTEwIDEwOjQwOjMwLjEzNDQ5NjQyMiAtMDAwMApAQCAt
MSw1ICsxLDYgQEAKLUNDICAgICA9IEBDQ0AgQENGTEFHU19NQUNISU5FQAotQ0ZMQUdTID0gQENG
TEFHU0AKK0NDICAgICAgPSBAQ0NAIEBDRkxBR1NfTUFDSElORUAKK0NGTEFHUyAgPSBAQ0ZMQUdT
QAorTERGTEFHUyA9IEBMREZMQUdTQAogCiAKIGFsbDogd2FtMm1hQEVYRV9TVUZGSVhACkBAIC0x
Miw3ICsxMyw3IEBACiAJJChDQykgJChDRkxBR1MpIC1jIHdhbTJtYS5jCiAKIHdhbTJtYUBFWEVf
U1VGRklYQDogd2FtMm1hQE9CSl9TVUZGSVhAIHdhbV9wYXJzZXJAT0JKX1NVRkZJWEAKLQkkKEND
KSAkKENGTEFHUykgQENDX0VYRV9OQU1FX09QVEB3YW0ybWFARVhFX1NVRkZJWEAgd2FtMm1hQE9C
Sl9TVUZGSVhAIHdhbV9wYXJzZXJAT0JKX1NVRkZJWEAKKwkkKENDKSAkKExERkxBR1MpIEBDQ19F
WEVfTkFNRV9PUFRAd2FtMm1hQEVYRV9TVUZGSVhAIHdhbTJtYUBPQkpfU1VGRklYQCB3YW1fcGFy
c2VyQE9CSl9TVUZGSVhACiAKIAogY2xlYW46Cg==


--=-53JYAr6q1u1vXmkN7Rq8--