pathchk bug

"Tim J. Robbins" <[email protected]> Wed, 22 May 2002 10:54:43 +1000
Newsgroups gmane.comp.gnu.sh-utils.bugs
Message-ID <[email protected]>
I believe there's a bug in the pathchk utility in GNU sh-utils 2.0j.
Instead of checking the return value of the function against zero, it checks
the address of the function, which is never equal.

The fix is trivial:

--- pathchk.c.old	Tue May 21 20:29:23 2002
+++ pathchk.c	Tue May 21 20:30:38 2002
@@ -303,7 +303,7 @@
       if (!last_elem)
 	{
 	  exists = dir_ok (path);
-	  if (dir_ok == 0)
+	  if (exists == 0)
 	    {
 	      free (parent);
 	      return 1;


Tim