Re: Embedding inputlang as information
Lorenzo Bettini <[email protected]> Wed, 30 Mar 2011 16:55:38 +0200
| Newsgroups | gmane.comp.gnu.source-highlight.general |
|---|---|
| Message-ID | <[email protected]> |
Hi there I still haven't had time to work on this. However, your patch looks OK. As I said in my previous email I think I will not add that additional argument in the constructor, but make it settable in a set method in order not to break compatibility, or probably add an overloaded constructor with the additional parameter. In the meantime, could you use your patched version for your web app? cheers Lorenzo On 03/30/2011 04:51 PM, Masatake YAMATO wrote: > Hi, > > Any progress about reviewing? > I need the input lang information in my web application:). > > Masatake YAMATO > >> On 03/02/2011 08:49 PM, Masatake YAMATO wrote: >>> Hi, >>> >>> I'd like you to review my patch. >>> The patch embeds input lang used in highlighting into the output xhtml >>> file. >> >> Hi there >> >> thanks for the interesting patch! :) >> >> I'll check it; as for now, I can say that I can modify it in order not >> to break abi compatibility (e.g., the input lang additional parameter >> can be set with a set method so not to change the method/constructor >> signature for instance). >> >> cheers >> Lorenzo >> -- Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino ICQ# lbetto, 16080134 (GNU/Linux User # 158233) HOME: http://www.lorenzobettini.it MUSIC: http://www.purplesucker.com http://www.myspace.com/supertrouperabba BLOGS: http://tronprog.blogspot.com http://longlivemusic.blogspot.com http://www.gnu.org/software/src-highlite http://www.gnu.org/software/gengetopt http://www.gnu.org/software/gengen http://doublecpp.sourceforge.net