Re: Building Diffutils with MinGW
Paul Eggert <[email protected]>
| Newsgroups | gmane.comp.gnu.utils.bugs |
|---|---|
| Organization | UCLA Computer Science Department |
| Message-ID | <[email protected]> |
On 05/05/2012 02:12 AM, Eli Zaretskii wrote: > I don't understand why should something like that be done by a > separate script, since the top-level configure already includes > multiple tests for mingw* configurations. These are imported from gnulib, which has some maintainers that worry about mingw*. It's no extra work to use them, since they don't affect the diffutils code proper. > #include <dirent.h> > #ifndef _D_EXACT_NAMLEN > # define _D_EXACT_NAMLEN(dp) strlen ((dp)->d_name) > #endif > > is sub-optimal for systems that have the d_namlen member in struct > dirent, but don't define _D_EXACT_NAMLEN. Yes, that's right. The code works correctly on such systems, and nobody's bothered to implement any such minor tuning.