Re: Comparing binary files with Diff 3.2 compiled with MinGW

Eli Zaretskii <[email protected]>
Newsgroups gmane.comp.gnu.utils.bugs,gmane.comp.lib.gnulib.bugs
Message-ID <[email protected]>
> From: Bruno Haible <[email protected]>
> Cc: [email protected], [email protected]
> Date: Sat, 12 May 2012 23:28:12 +0200
> 
> >         (O_TEXT) [!O_BINARY]: Define if not defined.
> 
> Why? You don't need it in the diffutils change.

Yes, I do.  See this line:

	      (void) setmode (current->desc, O_TEXT);

> This part is basically OK, but lacks comments and a unit test.
> Here's a proposed patch. It passes all tests on glibc, mingw, MSVC, Cygwin.

Thanks.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.