Re: Release of version 4.13.3 of sharutils

On 01/08/13 00:43, Petr Pisar wrote:
> On 2013-01-07, Bruce Korb <[email protected]> wrote:
>> .tar.gz:         ftp://ftp.gnu.org/gnu/sharutils/sharutils-4.13.3.tar.gz
> 
> Great, this archive works even on big endian.

Good news and bad news :

> I just spotted few issues you should know about:
> 
> (1) _() is defined multiple times:
> gcc -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I. -I..  -I../libopts -I. -I.. -I../lib -I../intl  -Wno-format-contains-nul -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m31 -march=z9-109 -mtune=z10 -Wno-format-contains-nul -c uudecode-opts.c
> uudecode.c:62:0: warning: "_" redefined [enabled by default]
> In file included from uudecode.c:56:0:
> uudecode-opts.h:178:0: note: this is the location of the previous definition

Missed the double define guard.  Thank you.

> (2) uuencode.5 uses undefined macro `.'. That's because leading comment
> with license starts with bad empty request:
> 
> '.\" Copyright
> 
> The apostrophe should [not] be there:
> 
> .\" Copyright

I remember fixing a bunch of those years ago.  I bet this got overlooked.
(Or magically re-introduced.)

Thank you. - Bruce