Re: Problem building sharutils 4.14 on AIX 6.1

On 10/21/2013 12:14 PM, Thomas Jahns wrote:
> Hello,
> 
> I built sharutils 4.14 on AIX 6.1 and initially got the following errors when
> compiling scribble.c:
> 

> So I gathered scribble.c indirectly included a home-brew version of unistd.h
> that configure generated. I was able to fix above problem by adding an
> 
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif

The #ifdef HAVE_CONFIG_H is needless fluff.  We _know_ that we have
config.h, so just unconditionally include it.  But yes, any projec that
uses gnulib MUST include "config.h" prior to any system headers, so this
is a bug in sharutils.  Furthermore, gnulib comes with a syntax check
mechanism that scans the code base for problems like these; maybe it's
worth investigating the use of that syntax checker before the next
sharutils release.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJSZZh/AAoJEKeha0olJ0NqUrkH/RflsrICifOz3aAJiELiEypw
nWljglSUeT+S9BCX/sclfnsLQGsd98tUEOWtrnRW09Wqo83cdYuJ8E/9PMR+nHih
1vuxGhrpBhB/DpSsi3lkOplOr5R0TVj7BK4QQ+MkFkq5eWpBQFqa5lRntxg5ekfY
0nRMsUpGZF9RsYwGYHh9teDu+ulo4PJ5qUcRsSuCNooD7vF931+ftLBvATLpBmlF
Eypuk/QQEPLOvpMm2r2xl4mkbsqkxomTzWDBFu5vdiOaHcFHxbCbpzVxI6A4KcX/
4fDaqEaiF90jxh17eYeChMgeK7iRsUOsGpGN7t9uRDMX2zgrDudbnXOz8tJSjZ0=
=Iiz6
-----END PGP SIGNATURE-----