Re: [sharutils] find_archive() passes off_t to fseek()

Petr Pisar <[email protected]> Mon, 2 Dec 2013 08:35:02 +0100

Newsgroups	gmane.comp.gnu.utils.bugs
Message-ID	<[email protected]>

On Mon, Dec 02, 2013 at 08:27:01AM +0100, Petr Pisar wrote:
> Hello,
> 
> current (4.14) src/unshar.c:find_archive() has third argument of type off_t,
> and passed the value to fseek(3) function which expects long. Standard library
> offers fseeko(3) for this reason.
> 
> I propose replace fseek() call with fseeko().
> 

Similar bug is at ftell() calls which returns long, but you assign the value
into off_t. There is ftello() again.

-- Petr

signature.asc (application/pgp-signature, 230 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iF4EABEIAAYFAlKcOCUACgkQEsnFx2fG+qJnbAD/UZ4GesnMQgtKR4lBfgqT+dqr
Idn3kllDKULp75JJVlQA/RH3QaFqYwjlRCHr/myyzduRUT2UkpGJ9gqyWvry02d7
=YGfY
-----END PGP SIGNATURE-----