Re: [PATCH 0/4] Cross compiling sharutils

On 05/19/2015 05:23 PM, Bruce Korb wrote:
> 
>> 2) Use a configure check to detect whether the host OS *requires*
>> binary mode
>>    for that particular popen call.  It seems the patch was introduced for
>>    cygwin, unfortunately I don't really have access to a cygwin
>> machine to
>>    check whether that makes a difference and to propose a check here. 
>> In the
>>    bug-gnulib@ thread, Eric proposed using O_BINARY to detect that,
>> perhaps
>>    that's a possibility?

You probably don't even need a configure check.  As in simply:

popen(..., O_BINARY ? "rb" : "r")

That is, the few platforms where O_BINARY is non-zero probably already
support "rb" as a mode for popen (are there any besides Cygwin and mingw?).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVW+oFAAoJEKeha0olJ0NqQGQH/36YwcP8WgTRakcDUIBgWh7T
kTN+UhadMM9Ez1rkZrM3TV6D5UDzg87A7gsr2fD5aVbyOCBea7Ff8SEmTNd9t1Y3
8m3f8RXq0/CkTX25gygZ0ZHNXh3pR2HidhJhXJCAFIjuegwfY7izn5cHekTmi4YR
tJ8QUebBmin7vEicSpHsivSuskojQwXg2ikMtHuc2XBHXUGEdJnlbpoqPMuzPDzH
5SrtgzPEOtiMUdgfoprQ6v9UuXKiCaGeOMU8QbmDykboXd94/n5USnTXjPHNkSXv
+aZbi+ruV5YK/TUOONx3LMDgI6dQvn/XhyaadJb2s0W+k6QdgxrvD2JQ6dy6uvE=
=ZJ4n
-----END PGP SIGNATURE-----