Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen

Filipe Brandenburger <[email protected]> Thu, 21 May 2015 21:38:51 -0700

Newsgroups	gmane.comp.gnu.utils.bugs
Message-ID	<CADU+-uD_8ksJGJfNHVq73ktXvLGZJitJcOhaY5Buf-TtL4t-Ng@mail.gmail.com>

Hi Bruce,

On Thu, May 21, 2015 at 5:51 PM, Bruce Korb <[email protected]> wrote:
> OK, I think this will work. [9999-current.diff]

Yes that looks good!

While at it, you might want to get rid of FOPEN_READ_BINARY and
FOPEN_WRITE_BINARY from here:
http://git.savannah.gnu.org/cgit/sharutils.git/tree/lib/system.h#n102

And replace their use with "r" FOPEN_BINARY and "w" FOPEN_BINARY, I
think there are only two uses of each.

Cheers!
Filipe