Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen

Bruce Korb <[email protected]> Fri, 22 May 2015 08:32:30 -0700
Newsgroups gmane.comp.gnu.utils.bugs
Organization FSF
Message-ID <[email protected]>
On 05/22/15 02:15, Andreas Schwab wrote:
>>     {
>> -    FILE * in_fp = popen (cmdline, "r");
>> +    FILE * in_fp = popen (cmdline, "r" TEXT_MODE);
>
> Didn't you mean FOPEN_TEXT?

Indeed, and yet it built and went through "make distcheck".
And, yes, the patch included a non-related issue.  Someone came up
with a tortured uu-encoded file that would cause uudecode to seg fault.
The patch was against the v4.15.1 tag.

Thank you all!

Regards, Bruce