[PATCH] Avoid usage of PATH_MAX.
Jan Nieuwenhuizen <[email protected]> Sat, 07 Mar 2020 15:54:11 +0100
| Newsgroups | gmane.comp.gnu.utils.bugs |
|---|---|
| Message-ID | <[email protected]> |
--=-=-= Content-Type: text/plain Hi! Initially I sent this patch to [email protected], through fencepost, and got a bounce. Also, I went to look for the archives, but it seems that bug-less is not a list? Greetings, janneke --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Avoid-usage-of-PATH_MAX.patch From ef652341ed8b2c14ac40312ccd4ed329cb69fd0c Mon Sep 17 00:00:00 2001 From: Jan Nieuwenhuizen <[email protected]> Date: Sat, 7 Mar 2020 14:57:19 +0100 Subject: [PATCH] Avoid usage of PATH_MAX. * filename.c (lrealpath): Have realpath allocate the buffer. Fixes compilation on the Hurd and avoids possible buffer overflow on other systems. --- filename.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/filename.c b/filename.c index e420837..faa71b0 100644 --- a/filename.c +++ b/filename.c @@ -795,9 +795,9 @@ lrealpath(path) char *path; { #if HAVE_REALPATH - char rpath[PATH_MAX]; - if (realpath(path, rpath) != NULL) - return (save(rpath)); + char *rpath = NULL; + if ((rpath = realpath(path, rpath)) != NULL) + return (rpath); #endif return (save(path)); } -- 2.24.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Jan Nieuwenhuizen <[email protected]> | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-=--