Re: XBoard 4.9.0 release
"H.G. Muller" <[email protected]> Tue, 10 May 2016 09:31:52 +0200
| Newsgroups | gmane.comp.gnu.xboard.devel |
|---|---|
| Message-ID | <[email protected]> |
This looks like the line simply gets clipped because of insufficient buffer size. And on trying to activate it, it might be clipped even shorter than on writing. Encountering an invalid option name still is a fatal error when the options were not coming from a settings file (where recovery is possible by skipping to the next line, and where it was pretty annoying that after running a newer test version of WinBoard, the old version would crash because of the new options it did not knowthat were stored in the settings file). The "logout" is now always sent to an ICS after a fatal error, to prevent the ICS from starting a new game when XBoard is waiting for user confirmation of the fatal-error popup before actually exiting (which you would then forfeit on time). I will check which buffers the theme definition passes through, and enlarge those. It would of course also be helpful if at some point (e.g. creating the line in the -themeNames option in LoadTheme()) XBoard would recognize the long path names obtained from the file chooser as being in its DATADIR (which here is "/Applications/Chess/Xboard/XBoard.app/Contents/Resources/share/xboard"?), and replace it by ~~. This would of course not help against general use of long path names, but it would surely make the theme lines more readable in the typical case: "Marble(Blue)" -ubt true -lbtf "~~/themes/textures/Transparent/stone-marble2-texture.png" -dbtf "~~/themes/textures/Transparent/stone-marble1-texture.png" -lbtm 1 -dbtm 1 -lsc #cbdce1 -dsc #1b6883 -ub false -upf false -pid "~~/themes/Habsburg" -trueColors false -wpc #ededed -bpc #000000 -hsc #fff826 -phc #FF0000 Op 5/10/2016 om 5:52 AM schreef Joshua Pettus: > I hope I'm not to late. I fear something is a little sick here. I > created a theme and this is what was saved: > > > "Marble(Blue)" -ubt true -lbtf > "/Applications/Chess/Xboard/XBoard.app/Contents/Resources/share/xboard/themes/textures/Transparent/stone-marble2-texture.png" > -dbtf > "/Applications/Chess/Xboard/XBoard.app/Contents/Resources/share/xboard/themes/textures/Transparent/stone-marble1-texture.png" > -lbtm 1 -dbtm 1 -lsc #cbdce1 -dsc #1b6883 -ub false -upf false -pid > "/Applications/Chess/Xboard/XBoard.app/Contents/Resources/share/xboard/themes/Habsburg" > -trueColors false -wpc #ededed -bpc #000000 -hsc #fff826 -phc #FF0 > > Only when I select this theme, xboard crashes to desktop with: > > > xboard-bin: Unrecognized argument -p > logout > > Clearly something is odd with the way the line is interpreted or > saved. the -p came from the partial -phc value. But even then should > xboard CDT in this manner with no error outside of the terminal? > > Josh > > > > > On 5/9/16 4:24 AM, H.G. Muller wrote: >> >> >> Op 5/9/2016 om 8:39 AM schreef Arun Persaud: >>> If you want them translated, I can easily upload another >>> dev-release. Up >>> to you... >> I think it would be better to just release 4.9.0. We could go on >> forever making dev-releases, >> and by the time all translations got we would likely already have >> added new strings >> that need to be translated. >> >> So let's just release what we have, and when we received all .po >> files pertaining to it, >> we just release a 4.9.1 with those. We might have bug-reports and >> fixes in the mean >> time as well, so it is never a bad idea to have an x.y.1 release >> shortly after the x.y.0 release. >> We could even adopt that as a policy for future releases. String >> freezes are just not practical; >> it is always better to have an item with an untranslated name in the >> UI than not having >> the item at all. Or postponing the release, leaving people with >> unfixed bugs in the previous >> version. >> > > >