Re: More CRUT breakage

Brian Paul <[email protected]> Tue, 11 Jan 2005 16:48:16 -0700
Newsgroups gmane.comp.graphics.chromium.devel
Message-ID <[email protected]>
Mike Houston wrote:
> Window resizing is no longer working correctly.  Try crut_fan.conf with 
> resizable set to 1.  It seems that the changes to render/readback have 
> slightly borked CRUT, or at least the some of the feedback paths.  
> Raptor now no longer runs correctly, so I'm starting with the simple 
> cases first.

Mike, give this patch a try.

I'd have to go back through my recent check-ins to know exactly why 
this stopped working.  But, the patch below fixes an oversight that's 
been present all along.

I'm tempted to add a 'track_window_size' option to the 
readback/binaryswap SPUs to supplement the 'resizable' option.  These 
two options would really control two distinct things.

-Brian
patch (text/plain, 693 B)
Index: renderspu_glx.c
===================================================================
RCS file: /cvsroot/chromium/cr/spu/render/renderspu_glx.c,v
retrieving revision 1.49
diff -r1.49 renderspu_glx.c
1448,1449c1448,1456
< 		XGetGeometry(window->visual->dpy, window->window, &root,
< 								 &x, &y, &width, &height, &bw, &d);
---
> 		if ((render_spu.render_to_app_window || render_spu.render_to_crut_window)
> 				&& window->nativeWindow) {
> 			XGetGeometry(window->visual->dpy, window->nativeWindow, &root,
> 									 &x, &y, &width, &height, &bw, &d);
> 		}
> 		else {
> 			XGetGeometry(window->visual->dpy, window->window, &root,
> 									 &x, &y, &width, &height, &bw, &d);
> 		}