RE: Texture crashes being caused by pack_texture.c rev 1.35

Mike wrote:

> I tracked things down to pack_texture.c in the 1.35 change list which is 
> causing the texture crashes for me.  It looks like some of the additions 
> of crPackFree()'s are incorrect and freeing NULL pointers...  We need to 
> take a longer look at that change list and probably back it out for now.

I think the proper fix is to simply remove the crPackFree() calls from
those functions.  When crHugePacket() is called, we wind up in a SPU
function like packspuHuge() or tilesortHuge() which call crPackFree()
themselves.

We should probably add a comment to crHugePacket() in pack_buffer.c to
indicate that the caller should _not_ call crPackFree() and that it's up to
the SPU routine called via pc->SendHuge() to do so.

-Brian


--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .




-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click