Re: Texture crashes being caused by pack_texture.crev 1.35

I agree.  Whoever calls crPackAlloc() should call crPackFree().  I was
hesitant about that though because of the buffered vs. non-buffered cases. 
They're different code paths.  See the IS_BUFFERED() test in
crHugePacket().  But it looks like crPackFree() does the same test so it
should be safe to call it all the time.

I'd say go ahead and check in your patch.

-Brian


Original Message:
-----------------
From: Michael Houston [email protected]
Date: Tue, 28 Jun 2005 12:53:30 -0700
To: [email protected], [email protected]
Subject: Re: [Chromium-dev] Texture crashes being caused by
pack_texture.crev 1.35


Actually, I think the other way around makes more sense, i.e. the caller 
allocates the packet, so I think they should have to free it as well.  I 
have a patched tree that already does this.  Most of the functions that 
use HugePacket currently issue the free...

-Mike

[email protected] wrote:

>Mike wrote:
>
>  
>
>>I tracked things down to pack_texture.c in the 1.35 change list which is 
>>causing the texture crashes for me.  It looks like some of the additions 
>>of crPackFree()'s are incorrect and freeing NULL pointers...  We need to 
>>take a longer look at that change list and probably back it out for now.
>>    
>>
>
>I think the proper fix is to simply remove the crPackFree() calls from
>those functions.  When crHugePacket() is called, we wind up in a SPU
>function like packspuHuge() or tilesortHuge() which call crPackFree()
>themselves.
>
>We should probably add a comment to crHugePacket() in pack_buffer.c to
>indicate that the caller should _not_ call crPackFree() and that it's up to
>the SPU routine called via pc->SendHuge() to do so.
>
>-Brian
>
>
>--------------------------------------------------------------------
>mail2web - Check your email from the web at
>http://mail2web.com/ .
>
>
>
>
>-------------------------------------------------------
>SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
>from IBM. Find simple to follow Roadmaps, straightforward articles,
>informative Webcasts and more! Get everything you need to get up to
>speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
>_______________________________________________
>Chromium-dev mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/chromium-dev
>  
>

--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .




-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click