Re: [Crystal-cvs] SF.net SVN: crystal:[38108] CS/trunk/docs/texinfo/build

Eric Sunshine <[email protected]>
Newsgroups gmane.comp.graphics.crystalspace.devel
Message-ID <CAPig+cQsA3d6-3f+2u8syTKnmYuW=HUCztts_1-2QKuOpHowZg@mail.gmail.com>
Thanks for documenting the work-arounds you used to get CS building on
Lion. Additional comments below (inline)...

On Sun, May 27, 2012 at 3:39 PM,  <[email protected]> wrote:
> Revision: 38108
> Added Paths:
>    CS/trunk/docs/texinfo/build/problems/macosx.txi

My guess is that people will likely overlook a "Problems" section in
the manual. It might be more helpful simply to incorporate all of this
information directly into the normal OSX build instructions so that
they can not be so easily overlooked.

> +...resulting in a failure to compile CS by returning a \x91generic thunk\x92 error.

Use Texinfo directive @samp{generic thunk} instead.

> +@example
> +which gcc -> /usr/bin/gcc
> +ln -s -f /usr/bin/i686-apple-darwin11-gcc-4.2.1 /usr/bin/gcc
> +@end example

Better would be to instruct the user to specify the correct compiler
at 'configure' time:

  ./configure CC=/usr/bin/i686-apple-darwin11-gcc-4.2.1 CXX=...

This way we don't muck up the build system in general.

> +@subsubheading Undefined symbols for architecture i386: "_main"

Refresh my memory: Did we verify that this is still needed once
-bundle is restored?

> +Gcc version 4.2.1 mentioned above can require a @code{main()} dummy function...

Assuming that this is still needed with -bundle restored, it should be
perfectly safe to add it unconditionally for all versions of Xcode and
OSX. Consequently, it would be better just to go ahead and commit this
change to macosx/csosdef.h right now on trunk and 2.0 rather than
documenting that people need to make the change manually. Please feel
free to do so.

> +If this is the case double check if the \x91-bundle\x92 flag (@code{PLUGIN.LFLAGS})...

As noted earlier, given that the unpolished and not-properly-explained
removal of -bundle was not intended to be merged back into trunk, it
probably would be fine to revert that change in trunk and 2.0 at this
time. (At any rate, if -bundle removal is needed in some
configurations, it is better to detect it via ./configure rather than
removing it unconditionally, so reverting the change is still likely
the correct thing to do.)

> +@example
> +file vfs.csbundle -> vfs.csbundle: Mach-O bundle i386
> +@end example
> \ No newline at end of file

Missing newline.

> --- CS/trunk/docs/texinfo/build/problems.txi    2012-05-27 19:36:53 UTC (rev 38107)
> +++ CS/trunk/docs/texinfo/build/problems.txi    2012-05-27 19:39:16 UTC (rev 38108)
> +@importss{build,problems,macosx.txi}
> \ No newline at end of file

Ditto.

-- ES

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.