Re: [Crystal-cvs] SF.net SVN: crystal:[38126] CS/branches/soc2012/editor

Thanks Mathew for pointing all of this.

> csBasicModifiableDescription should not store an array of parameters as a
> data member. Instead, csBasicModifiableDescription::GetParameter and
> ::GetParameterByIndex should return newly constructed parameters.

Actually, the return value that was initially thought for
iModifiableDescription::GetParameter() was a 'const
iModifiableParameter*', because it was assuming that if the user wants to
access to the iModifiableDescription, then he will also access to the
iModifiableParameter's. For this reason, this signature can probably be
put back, and the iModifiableDescription will therefore have to keep an
internal array of parameters as a data member.

Also, I didn't noticed it before, but the methods
iModifiableParameter::Get/SetParameterValue() that you added need to be
removed. The values of the parameters are accessed only directly through
the iModifiable. The iModifiableDescription is allocated only if the user
don't know how to use the iModifiable.

> csTestModifiable should not store a description as a data member. Instead,
> csTestModifiable::GetDescription should return a newly constructed
> description.

Yes, here this change needs to be made.



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/