Re: [Crystal-cvs] SF.net SVN: crystal:[38208] CS/branches/soc2012/vfs

-------- Original-Nachricht --------
> Datum: Sun, 24 Jun 2012 08:39:39 +0000
> Von: [email protected]
> An: [email protected]
> Betreff: [Crystal-cvs] SF.net SVN: crystal:[38208] CS/branches/soc2012/vfs

> - Reverted unintentional r3dopengl.cfg changes.
> - Removed C++0x LL suffix from some constants.
> - Added some comments in legacy code.
> - Added new file 'native.cpp' along with (incomplete) code for new
> iFileSystem/iFile implementation.
> - Updated definition of csFilePermission class; removed redundant members.

I think the commit could've been split up into multiple commits.
E.g. the r3dopengl.cfg revert. Probably also some of the VFS stuff.

>    csFilePermission(int octal)
> -  : read(!!(octal & 0x04)), write(!!(octal & 0x02)), execute(!!(octal &
> 0x01))
>    {
> +    user_read      = (octal >> 8) & 0x01;

You could've also written the flags in actual octal, ”(octal & 0800) != 0” and so on.


> -                                                        =
> (uint64_t)~0LL);
> +                                                        = ~(uint64_t)0);

You can write UINT64 constants by using the macro CONST_UINT64().

-f.r.
-- 
NEU: FreePhone 3-fach-Flat mit kostenlosem Smartphone!                                  
Jetzt informieren: http://mobile.1und1.de/?ac=OM.PW.PW003K20328T7073a

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop