Re: [Crystal-cvs] SF.net SVN: > crystal:[38208] CS/branches/soc2012/vfs
Eunsoo Roh <[email protected]>
| Newsgroups | gmane.comp.graphics.crystalspace.devel |
|---|---|
| Message-ID | <[email protected]> |
> I think the commit could've been split up into multiple commits.> E.g. the r3dopengl.cfg revert. Probably also some of the VFS stuff.
Thanks for your suggestion. I agree with your idea to split up commits.
> > csFilePermission(int octal)
> > - : read(!!(octal & 0x04)), write(!!(octal & 0x02)), execute(!!(octal &
> > 0x01))
> > {
> > + user_read = (octal >> 8) & 0x01;
>
> You could've also written the flags in actual octal, ?(octal & 0800) != 0? and so on.
>
That looks much more clear! I've updated the code with that.
> > - =
> > (uint64_t)~0LL);
> > + = ~(uint64_t)0);
>
> You can write UINT64 constants by using the macro CONST_UINT64().
So, the best way would be: ~CONST_UINT64(0) ?
Again, thanks for your advice.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop