Re: Current Post Processing support

Hi Pedro,

On Mon, 2013-04-22 at 12:14 -0300, Pedro Arthur wrote:
> Currently my proposal idea consists of post-processing efects:
> - Validate and merge the code (mainly SSDO) from GSOC 2011 branch
'CS/branches/soc2011/globalillum/' as a post effect

I've commited in r39275 the code that I started for the SSDO conversion,
see the commit comments for more info on the relevant files.

About the work that would still need to be done:
- 1: The conversion into a post effect is in early development status
and may need quite some time to be done (I would say at least two weeks,
the harder being to understand deeply the behavior of the SSDO stuff).
- 2: The branch still needs to be updated with the changes that have
been made last year by Matthieu to the deferred RM. The SSDO
implementation would need to be updated too.
- Not sure what would be the best: work on 1 before 2 or vice versa?
Maybe complete 1 as it has already been started, then go for 2. No real
idea of the complexity of 2 actually, in the best case there is nothing
to do.
- The changes on the post effect management were a priori completed and
tested. You might however find some problem when using them with more
concrete examples and might have therefore to look into it.

> - Implement SSAO
> - DoF + Bokeh
> - Motion Blur 
> And also (if time permits):
> - Volumetric Lighting
> - underwater caustics.

The idea list seems great. You can now improve your proposition by
developing more concretely the techniques you are talking about, eg the
render manager and render buffers that you would use for each technique,
the technique of motion blur that you are aiming for, etc.

> - For each feature implement a demo app + documentation

That's true that a post-effect browser might be interesting so that one
can try them without the need of leaving the application and launching
another. You can add that in your project if you are interested in it,
although this should a priori not be a priority.

> Is it enough techniques/work for the GSoC?

Yes, that seems already a good amount of work, this should be OK.

> The post-processing manager:
> When using
"postMgr->AddLayersFromFile("/data/posteffects/effect.xml");"
> always return true even if the shaders have wrong sintax and not
compile, you get only a black screen without any notification.

That's a priori not the expected behavior and at least wrong syntax
should be detected and a negative value returned. That might be a bug
and you can clearly introduce the fixing of such problems in your
project if you want to.

> Reposting bugs: I reported some bugs necessary to work with the
post-processing already with the patch fix, but it wasn't reviewed nor
get any comment/response. is it common or lack of time from reviewers?

Yeah, we are a bit lazy sometimes :)

This is now made, I've reviewed and commited your fixes in r39276 and
r39277, thanks for them!



------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr