Re: [Crystal-cvs] SF.net SVN: crystal:[39440] CS/trunk/plugins/mesh/terrain/persist/terrain2/ loader.cpp

When Frank mentioned[1] that this was a significant behavioral change,
I think he was speaking primarily of the added 'return false' which
triggers in debug but not release mode. In his suggestion (a), step 1
is to "demote" the diagnostic from an error to a warning (which you do
here), and step 2 is to "keep going" by removing the 'return false'
(not done here).

[1]: http://article.gmane.org/gmane.comp.graphics.crystalspace.devel/4448/

On Mon, Jul 1, 2013 at 11:39 AM,  <[email protected]> wrote:
> Revision: 39440
>           http://sourceforge.net/p/crystal/code/39440
> Author:   kickvb
> Date:     2013-07-01 15:39:11 +0000 (Mon, 01 Jul 2013)
> Log Message:
> -----------
> Terrain2 loader: Demoted the report message introduced in r39438 to a warning instead of an error in order to have the same global behavior in debug and release modes. Thanks to Frank for his comment about this.
>
> Revision Links:
> --------------
>     http://sourceforge.net/p/crystal/code/39438
>
> Modified Paths:
> --------------
>     CS/trunk/plugins/mesh/terrain/persist/terrain2/loader.cpp
>
> Modified: CS/trunk/plugins/mesh/terrain/persist/terrain2/loader.cpp
> ===================================================================
> --- CS/trunk/plugins/mesh/terrain/persist/terrain2/loader.cpp   2013-07-01 15:00:04 UTC (rev 39439)
> +++ CS/trunk/plugins/mesh/terrain/persist/terrain2/loader.cpp   2013-07-01 15:39:11 UTC (rev 39440)
> @@ -370,8 +370,9 @@
>        const char* name = child->GetContentsValue ();
>        if (name && fact->GetCell (name))
>        {
> -       synldr->ReportError (
> +       synldr->Report (
>           "crystalspace.terrain.object.loader.cell",
> +         CS_REPORTER_SEVERITY_WARNING,
>           child, "Another cell with the name %s already exists",
>           CS::Quote::Single (name));
>         return false;
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Crystal-cvs mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/crystal-cvs

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev