Changing iEngine::CreatePortalContainer signature

Matthieu Kraus <[email protected]> Thu, 09 Jan 2014 14:10:17 +0100
Newsgroups gmane.comp.graphics.crystalspace.devel
Message-ID <[email protected]>
Greetings,

after researching Ralph's issue with CreatePortal a bit I recognized  
that csEngine::CreatePortal sets the sector of the mesh (and  
accordingly prepares it for rendering and by extension for culling)  
prior to adding any vertices, i.e. it prepares a mesh without any  
vertices for rendering. As this doesn't seem valid to me at all, I'd  
like to change CreatePortal accordingly to set the sector/pos after  
being done creating the portal to prevent this from occuring. However  
the current signature of CreatePortalContainer (which is also exposed  
by iEngine) suggests that it should be fine to create and prepare such  
an invalid mesh.

Accordingly I'd like to remove the sector and pos arguments for  
CreatePortalContainer and add a note that the user is responsible for  
setting the position and sector after being done creating the portals  
belonging to that container and that doing so without a valid portal  
in the container may result in undefined behaviour.

If anyone has obligations about this way of handling invalid  
meshes/bumping iEngine, please let me know.

kind regards,
RlyDontKnow


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk