Re: Static source code analysis of crystalspace

On Tue, Feb 25, 2014 at 11:08 AM, John Smith <[email protected]> wrote:
> On Tue, Feb 25, 2014 at 4:59 PM, Matthieu Kraus
> <[email protected]> wrote:
>>
>> I don't have the time to check all by hand right now, but a quick check
>>
> Thank you for taking the time to look into at least some of the
> reports, and explaining them.
>
> I think ill just crawl back under my rock now

These are not necessarily all false positives. For instance, the
"assignment of undefined or garbage value" at [1] is certainly
suspect. If we know that that function is always called with non-zero
iNumSpokes, then it's a false positive, but if not, it's a legitimate
complaint. At the very least, that code would benefit from a
CS_ASSERT(iNumSpokes != 0).

John, we would be happy to grant you commit access to the repository
if you want to investigate the reported issues and patch the
legitimate ones.

[1]: http://lbalbalba.url.ph/clang/cs/report-ae26f9.html#EndPath

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk