Re: [CrystalSpace] #988: Remove unused variable in shadow.h (fix included)

#988: Remove unused variable in shadow.h (fix included)
---------------------------+------------------------------------------------
 Reporter:  ralphcampbell  |       Owner:  jorrit
     Type:  defect         |      Status:  new   
 Priority:  minimal        |   Milestone:        
Component:  renderer       |     Version:  V2.1  
 Keywords:                 |  
---------------------------+------------------------------------------------
Description changed by sunshine:

Old description:

> I found that 'matrix' is unused when compiling CS with --enable-debug.
> Perhaps it indicates some other problem.
> If not, then it should be removed.
>
> {{{
> Index: plugins/rendermanager/osm/shadow_osm.h
> ===================================================================
> --- plugins/rendermanager/osm/shadow_osm.h      (revision 39500)
> +++ plugins/rendermanager/osm/shadow_osm.h      (working copy)
> @@ -334,8 +334,6 @@
>              0, 0, 1, 0,
>              0, 0, 0, 1);
>
> -          CS::Math::Matrix4 matrix =
> rview->GetCamera()->GetProjectionMatrix();
> -
>            CS::Math::Matrix4 Mortho =
>              CS::Math::Projections::Ortho (-1, 1, 1, -1, 1, -1);
>
> }}}

New description:

 I found that `matrix` is unused when compiling CS with `--enable-debug`.
 Perhaps it indicates some other problem.
 If not, then it should be removed.

 {{{
 #!diff
 Index: plugins/rendermanager/osm/shadow_osm.h
 ===================================================================
 --- plugins/rendermanager/osm/shadow_osm.h      (revision 39500)
 +++ plugins/rendermanager/osm/shadow_osm.h      (working copy)
 @@ -334,8 +334,6 @@
              0, 0, 1, 0,
              0, 0, 0, 1);

 -          CS::Math::Matrix4 matrix =
 rview->GetCamera()->GetProjectionMatrix();
 -
            CS::Math::Matrix4 Mortho =
              CS::Math::Projections::Ortho (-1, 1, 1, -1, 1, -1);

 }}}

--

-- 
Ticket URL: <http://trac.crystalspace3d.org/trac/CS/ticket/988#comment:1>
CrystalSpace <http://www.crystalspace3d.org/>
Free open-source 3D SDK.
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk