Re: [CrystalSpace] #996: assimpldr.cpp compile error on Fedora 18

"CrystalSpace" <[email protected]> Sun, 04 Aug 2013 05:21:38 -0000
Newsgroups gmane.comp.graphics.crystalspace.tracker
Message-ID <[email protected]>
#996: assimpldr.cpp compile error on Fedora 18
---------------------------+------------------------------------------------
 Reporter:  ralphcampbell  |       Owner:  admin
     Type:  defect         |      Status:  new  
 Priority:  minor          |   Milestone:       
Component:  other plugins  |     Version:  V2.1 
 Keywords:                 |  
---------------------------+------------------------------------------------

Comment(by sunshine):

 Thanks. A few random comments:

  - It's sufficient to post only the `configure.ac` diff. The `configure`
 diff is something that we can generate (and not particularly interesting
 for review), so you can omit it.

  - When we commit `configure`-related changes, we always commit
 `configure.ac` first (along with other code related code changes) and then
 commit `configure` separately. This makes it simpler to merge or cherry-
 pick the `configure.ac` changes into another branch since such merges
 often are conflict-free, whereas `configure` changes frequently have
 conflicts when merged.

  - You should be able to test with other versions of `assimp` by
 downloading, building, and then installing them some place locally (like
 `$HOME/assimpinstall`). Then, configure CS with option `--with-
 assimp=$HOME/assimpinstall`.

  - This issue is the perfect example of why it is better to write
 ''feature'' checks with Autoconf rather than ''version'' checks, and
 likewise define macros saying whether a feature is available rather than a
 version. I think that would be the best approach for this case, so we
 should have one feature check for the new-style headers and one for the
 diagnostic macros.

-- 
Ticket URL: <http://www.crystalspace3d.org/trac/CS/ticket/996#comment:9>
CrystalSpace <http://www.crystalspace3d.org/>
Free open-source 3D SDK.
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk