Re: AquaTerm (all solved)

Erik Luijten <[email protected]> Sat, 1 Feb 2025 08:19:18 -0600
Newsgroups gmane.comp.graphics.gnuplot.devel
Message-ID <CAM4Pt-8nO+VrboB_PKNNT5Eu0w9XRTk2FCwY4a21ZxEWu0VrhQ@mail.gmail.com>
--===============4633746849289049943==
Content-Type: multipart/alternative; boundary="000000000000e72680062d15588e"

--000000000000e72680062d15588e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jun,

Yes, that resolves the problem! How do we proceed? Ideally, this bugfix
should be made in the distribution of AquaTerm. If this is hard, maybe I
can distribute compiled AquaTerm packages for ARM and Intel as "1.1.1
patchlevel 1" or so.

By the way, I have not checked for any unintended side effects in AquaTerm.

Best,

Erik

On Fri, Jan 31, 2025 at 7:06=E2=80=AFPM Jun. T <[email protected]=
p> wrote:

>
> > 2025/01/28 7:00, Ethan A Merritt <[email protected]> wrote:
> >
> > Also, can someone now check whether Bug #1969 "Aquaterm: plot using
> third column for color palette value loses every 2nd line" is still a
> problem or can now be closed?   Maybe I should close it anyhow, since the
> aquaterm project seems moribund.
> >     https://sourceforge.net/p/gnuplot/bugs/1969/
>
>
> > 2025/01/28 7:05=E3=80=81Erik Luijten <[email protected]>=E3=81=AE=
=E3=83=A1=E3=83=BC=E3=83=AB:
> >
> > I just checked. The problem still exists (screenshots below). I know
> nothing about AquaTerm, so cannot assist in resolving this, unfortunately=
.
>
> Could you please try the following patch when building AquaTerm.app?
> (I hope it has no bad side effects.)
>
> Jun
>
>
>
> --- AQTPlotBuilder.m.ORG        2012-07-30 23:39:50.000000000 +0900
> +++ AQTPlotBuilder.m    2025-02-01 09:10:01.000000000 +0900
> @@ -149,7 +149,15 @@
>     // FIXME: Use AQTEqualColor instead
>     if ((newColor.red !=3D _color.red) || (newColor.green !=3D _color.gre=
en)
> || (newColor.blue !=3D _color.blue) || (newColor.alpha !=3D _color.alpha)=
)
>     {
> +      int32_t count_save =3D _polylinePointCount;
>        [self _flushBuffers];
> +      if (count_save > 0) {
> +        // if color changes in the middle of polyline,
> +        // the last point of the path should be the
> +        // first point of the next path.
> +        _polylinePoints[0] =3D _polylinePoints[count_save - 1];
> +        _polylinePointCount =3D 1;
> +      }
>        _color =3D newColor;
>     }
>  }
>
>
>
>
>
> _______________________________________________
> gnuplot-beta mailing list
> [email protected]
> Membership management via:
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
>

--000000000000e72680062d15588e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Jun,<div><br></div><div>Yes, that resolves the=C2=A0pro=
blem! How=C2=A0do we proceed? Ideally, this bugfix should be made in the di=
stribution of AquaTerm. If this is hard, maybe I can distribute compiled Aq=
uaTerm packages for ARM and Intel as &quot;1.1.1 patchlevel 1&quot; or so.<=
/div><div><br></div><div>By the=C2=A0way, I have not checked for any uninte=
nded side effects in AquaTerm.</div><div><br></div><div>Best,</div><div><br=
></div><div>Erik</div></div><br><div class=3D"gmail_quote gmail_quote_conta=
iner"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jan 31, 2025 at 7:06=E2=
=80=AFPM Jun. T &lt;<a href=3D"mailto:[email protected]">takimot=
[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><br>
&gt; 2025/01/28 7:00, Ethan A Merritt &lt;<a href=3D"mailto:[email protected]"=
 target=3D"_blank">[email protected]</a>&gt; wrote:<br>
&gt; <br>
&gt; Also, can someone now check whether Bug #1969 &quot;Aquaterm: plot usi=
ng third column for color palette value loses every 2nd line&quot; is still=
 a problem or can now be closed?=C2=A0 =C2=A0Maybe I should close it anyhow=
, since the aquaterm project seems moribund.<br>
&gt;=C2=A0 =C2=A0 =C2=A0<a href=3D"https://sourceforge.net/p/gnuplot/bugs/1=
969/" rel=3D"noreferrer" target=3D"_blank">https://sourceforge.net/p/gnuplo=
t/bugs/1969/</a><br>
<br>
<br>
&gt; 2025/01/28 7:05=E3=80=81Erik Luijten &lt;<a href=3D"mailto:erik.luijte=
[email protected]" target=3D"_blank">[email protected]</a>&gt;=E3=81=AE=E3=
=83=A1=E3=83=BC=E3=83=AB:<br>
&gt; <br>
&gt; I just checked. The problem still exists (screenshots below). I know n=
othing about AquaTerm, so cannot assist in resolving this, unfortunately.<b=
r>
<br>
Could you please try the following patch when building AquaTerm.app?<br>
(I hope it has no bad side effects.)<br>
<br>
Jun<br>
<br>
<br>
<br>
--- <a href=3D"http://AQTPlotBuilder.m.ORG" rel=3D"noreferrer" target=3D"_b=
lank">AQTPlotBuilder.m.ORG</a>=C2=A0 =C2=A0 =C2=A0 =C2=A0 2012-07-30 23:39:=
50.000000000 +0900<br>
+++ AQTPlotBuilder.m=C2=A0 =C2=A0 2025-02-01 09:10:01.000000000 +0900<br>
@@ -149,7 +149,15 @@<br>
=C2=A0 =C2=A0 // FIXME: Use AQTEqualColor instead<br>
=C2=A0 =C2=A0 if ((newColor.red !=3D _color.red) || (newColor.green !=3D _c=
olor.green) || (newColor.blue !=3D _color.blue) || (newColor.alpha !=3D _co=
lor.alpha))<br>
=C2=A0 =C2=A0 {<br>
+=C2=A0 =C2=A0 =C2=A0 int32_t count_save =3D _polylinePointCount;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0[self _flushBuffers];<br>
+=C2=A0 =C2=A0 =C2=A0 if (count_save &gt; 0) {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 // if color changes in the middle of polyline,=
<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 // the last point of the path should be the<br=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 // first point of the next path.<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 _polylinePoints[0] =3D _polylinePoints[count_s=
ave - 1];<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 _polylinePointCount =3D 1;<br>
+=C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0_color =3D newColor;<br>
=C2=A0 =C2=A0 }<br>
=C2=A0}<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
gnuplot-beta mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">gnu=
[email protected]</a><br>
Membership management via: <a href=3D"https://lists.sourceforge.net/lists/l=
istinfo/gnuplot-beta" rel=3D"noreferrer" target=3D"_blank">https://lists.so=
urceforge.net/lists/listinfo/gnuplot-beta</a><br>
</blockquote></div>

--000000000000e72680062d15588e--


--===============4633746849289049943==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============4633746849289049943==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gnuplot-beta mailing list
[email protected]
Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta

--===============4633746849289049943==--