Re: Ogg encapsulation

> It's really trivial to do this, two places in libmng_read.c, plus
> adding the bIgnoreCRC member to pData, and a subroutine for setting
> bIgnoreCRC (and function query-support for the new subroutine).  It will
> save *some* cpu, not a lot, since crc is pretty fast and getting much
> faster in zlib-1.2.1.  I've put code in pngcrush to skip CRC calculation
> and it doesn't save much time, percentage wise.

It would save two times. OGG would need to generate a valid CRC before 
passing it to libmng which would then validate a valid CRC, except for the 
very first test if Ralph made a coding mistake.... ;)
So I think it's worth putting in the little effort required.

But I think it's best if we would entirely skip reading the 4 CRC bytes, so as 
not to open up the field for people to turn the flag on just to bypass invalid 
CRC's created by buggy encoders!

Gerard


--
Send the message body "help" to [email protected]