Re: Endless loop in version 1.6.26
Glenn Randers-Pehrson <[email protected]>
| Newsgroups | gmane.comp.graphics.png.devel |
|---|---|
| Message-ID | <CA+PdXcs3ssqOLwrUAoOzitB3Mpqx=u3Oy4gpHTdwG+Ps0Tm72Q@mail.gmail.com> |
Backed out the change from pngrutil.c and pngpread.c, pushed to the git repos (libpng16 branch) Glenn On Tue, Nov 8, 2016 at 4:41 PM, John Bowler < [email protected]> wrote: > The same change breaks the 1.7 API to control how IDAT errors are > handled. Prior to the change the app could control whether to ignore > them and get a potentially corrupted but still usable image (1.7 fills > in the unreadable data to counter security issues) or to error out. > > With the change the error-out option no longer works for changes to > the zlib stream which change the image but don't invalidate the steam. > There are quite a lot of such changes! > > I don't see why it was necessary to duplicate functionality which > already exists; libpng 1.7 an already ignore detectable errors in the > zlib stream, why change the behavior in the case where it isn't doing > this? > > Not only that, but I can't see how this behavior can be switched > *off*; it is an unconditional removal of a security feature for all > applications of libpng. That has to be wrong. > > John Bowler > > ------------------------------------------------------------ > ------------------ > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > png-mng-implement mailing list > png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/png-mng-implement > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ png-mng-implement mailing list png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/png-mng-implement