Re: [libpng:bugs] #259 [PATCH] arm64 build fix with CMAKE
John Bowler <[email protected]>
| Newsgroups | gmane.comp.graphics.png.devel |
|---|---|
| Message-ID | <CAP7U39-_t=KFg90Jt-04Nyyiq-=w4xtR1Gg-nFMbq8X-VL000A@mail.gmail.com> |
On Sat, Dec 31, 2016 at 6:16 AM, Glenn Randers-Pehrson <[email protected]> wrote: > This was proposed on the libpng bug tracker at SourceForge: > > # set definitions and sources for arm > -if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "^arm") > +if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "^arm" OR ${CMAKE_SYSTEM_PROCESSOR} > MATCHES "^aarch64") > > Looks OK to me but I'm not equipped to test it. > That seems correct to me too, but I haven't tested it. AArch64 cross-builds succeed (minus actually executing the test suite of course) when driven from configure, no special #defines are required. With GCC the compiler must be up-to-date enough to set the correct architecture flags; 5.3, 5.4, 6.2 and 6.3 are fine, 4.x is not supported. John Bowler ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ png-mng-implement mailing list png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/png-mng-implement