Re: [PATCH] cmake: Default to PNG_ARM_NEON=off for arm targets

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1780289942-1665779216=:1659
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Fri, 14 Oct 2022, John Bowler wrote:

> I checked on arm64 Ubuntu and my Intel system.  Using the current libpng16
> HEAD with the patch for Intel both cmake and configure behave as I expect
> (with no arguments).
> The comment in the git change log is wrong, "cmake: Default to
> PNG_ARM_NEON=off for arm targets".

Indeed, after retesting the configure build, that part of the commit 
message (no hardware optimizations get autoenabled in the configure build) 
was clearly wrong - I'm sorry about that, that this incorrect and 
misleading comment now is fixed in git history...

While you do get hardware optimizations enabled by default in both the 
CMake and configure builds, in the CMake build it's done by building 
everything with -DPNG_ARM_NEON_OPT=2, while in the case of the configure 
build, it's done by having pngpriv.h enable it based on the compiler's 
default configuration.

// Martin

--8323329-1780289942-1665779216=:1659
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--8323329-1780289942-1665779216=:1659
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
png-mng-implement mailing list
png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

--8323329-1780289942-1665779216=:1659--