Re: Fix for INTEL_SSE

--===============2843620782739206871==
Content-Type: multipart/alternative; boundary="000000000000417b6205eb7a19f7"

--000000000000417b6205eb7a19f7
Content-Type: text/plain; charset="UTF-8"

>https://app.travis-ci.com/github/ctruta/libpng/jobs/586217704
>ld: error: libpng16.so.16.39.git: undefined reference to
png_init_filter_functions_sse2

The build configuration has to have failed to include intel/intel_init.c!

From my limited knowledge of cmake  it looks like CMakeLists.txt should
include it on line 162 and, indeed, it does on my cmake build.  I just did
"cmake ../code" then "make" and the intel files get compiled.

>https://ci.appveyor.com/project/ctruta/libpng/builds/45130105

A similar problem, in fact it looks the same; it would seem that the Intel
optimization files have been left out of the build without explicitly
turning the optimizations off but I can't work out what options were passed
to cmake (even the VS build seems to be using cmake!)

Note that all the CMakeLists.txt rules have the same set of bugs; they
explicitly turn things on or off.  Why it's going wrong in this case isn't
clear to me.  It is very clear that if PNG_INTEL_SSE_OPT is set to 0 (or,
indeed, negative) line 236 of pngpriv.h will not be parsed.

John Bowler <[email protected]>

--000000000000417b6205eb7a19f7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>&gt;<a href=3D"https://app.travis-ci.com/github/ctrut=
a/libpng/jobs/586217704">https://app.travis-ci.com/github/ctruta/libpng/job=
s/586217704</a><br></div><div>&gt;ld: error: libpng16.so.16.39.git: undefin=
ed reference to png_init_filter_functions_sse2</div><div><br></div><div>The=
 build configuration has to have failed to include intel/intel_init.c!</div=
><div><br></div><div>From my limited knowledge of cmake=C2=A0 it looks like=
 CMakeLists.txt should include it on line 162 and, indeed, it does on my cm=
ake build.=C2=A0 I just did &quot;cmake ../code&quot; then &quot;make&quot;=
 and the intel files get compiled.</div><div><br></div><div>&gt;<a href=3D"=
https://ci.appveyor.com/project/ctruta/libpng/builds/45130105">https://ci.a=
ppveyor.com/project/ctruta/libpng/builds/45130105</a></div><div><br></div><=
div>A similar problem, in fact it looks the same; it would seem that the In=
tel optimization files have been left out of the build without explicitly t=
urning the optimizations off but I can&#39;t work out what options were pas=
sed to cmake (even the VS build seems to be using cmake!)</div><div><br></d=
iv><div>Note that all the CMakeLists.txt rules have the same set of bugs; t=
hey explicitly turn things on or off.=C2=A0 Why it&#39;s going wrong in thi=
s case isn&#39;t clear to me.=C2=A0 It is very clear that if PNG_INTEL_SSE_=
OPT is set to 0 (or, indeed, negative) line 236 of pngpriv.h will not be pa=
rsed.</div><div><br></div><div><div><div><div dir=3D"ltr" class=3D"gmail_si=
gnature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div>John=
 Bowler &lt;<a href=3D"mailto:[email protected]" target=3D"_blank">jbowler@ac=
m.org</a><font color=3D"#000120"></font><u></u>&gt;</div><div><br></div></d=
iv></div></div></div></div></div></div>

--000000000000417b6205eb7a19f7--


--===============2843620782739206871==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============2843620782739206871==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
png-mng-implement mailing list
png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

--===============2843620782739206871==--