Re: RISC-V Vector patch

DragoČ™ Tiselice via png-mng-implement <png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> Fri, 2 Jun 2023 16:16:11 +0200
Newsgroups gmane.comp.graphics.png.devel
Message-ID <CAJ5AADuhNrzaH9LFLyVjgDjZjJOOxjfE0F5h=2n3PVMSK1gG4Q@mail.gmail.com>
--===============1865482787639274329==
Content-Type: multipart/alternative; boundary="00000000000092279805fd26327c"

--00000000000092279805fd26327c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The pull request on GitHub is more than a year old without any comments.
Are there any blockers to reviewing this? Is the lack of review caused by a
lack of testing infrastructure?

I'd be very happy to work on a solution for testing if this unblocks RISC-V
support.

Drago=C8=99

On Thu, Jun 1, 2023 at 6:13=E2=80=AFPM John Bowler <john.cunningham.bowler@=
gmail.com>
wrote:

> On Thu, Jun 1, 2023 at 12:39=E2=80=AFAM Drago=C8=99 Tiselice via png-mng-=
implement <
> png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> wrote:
>
>> Thank you for the advice. I have reached out to Cosmin on Gmail without
>> getting a reply back.
>>
>> Also, GitHub seems to be behind/unmaintained compared to SourceForge.
>>
>
> All the github repos and sourceforge (
> https://sourceforge.net/projects/libpng/) seem to be in step; the last
> change on sourceforge was on 12 February 2023 and the same goes for
> libpng16 on github.com (https://github.com/glennrp/libpng).  "master" and
> "tmp/develop" are up-to-date with libpng16.  I believe "master" and
> "tmp/develop" are identical to libpng16 on github,com; commits 0/0
> ahead/behind.
>
> This is the way it should be; the two "master" branches on sourceforge an=
d
> github should both point to the current major release (libpng16).  I neve=
r
> used sourceforge (well, not after the indemnification issue) and all
> development was done on github; it is likely that from time to time the
> branches on github pointed to something that was somewhat unstable.  Only
> tagged revisions are fully tested.  "tmp/develop" is new and, I assume, w=
as
> created to avoid that.
>
> I won't discuss the specific merge request here (discussions should go in
> a "pull" request on github) beyond pointing out:
>
> https://github.com/mschlaegl/libpng_rvv-doc
> https://github.com/mschlaegl/libpng_rvv
> https://github.com/glennrp/libpng/pull/405
>
> Plus observing that I suspect third party testing of these (mschlaegl)
> changes (preferably synced up to date with glennrp/libpng16) would
> certainly help validate them.
>
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement
>

--00000000000092279805fd26327c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">The pull request on GitHub is more than a year old without=
 any comments. Are there any blockers to reviewing this? Is the lack of rev=
iew caused by a lack of testing infrastructure?<div><br></div><div>I&#39;d =
be very happy to work on a solution for testing if this unblocks RISC-V sup=
port.</div><div><br></div><div>Drago=C8=99<br></div></div><br><div class=3D=
"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 1, 2023 at =
6:13=E2=80=AFPM John Bowler &lt;<a href=3D"mailto:john.cunningham.bowler@gm=
ail.com">[email protected]</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">=
On Thu, Jun 1, 2023 at 12:39=E2=80=AFAM Drago=C8=99 Tiselice via png-mng-im=
plement &lt;<a href=3D"mailto:png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" targ=
et=3D"_blank">png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org</a>&gt; wrote:<br></d=
iv><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><div dir=3D"ltr">Thank you for the advice. I have reached out to Cosmi=
n on Gmail without getting a reply back.<div><br></div><div>Also, GitHub se=
ems to be behind/unmaintained compared to SourceForge.</div></div></blockqu=
ote><div><br></div><div>All the github repos and sourceforge (<a href=3D"ht=
tps://sourceforge.net/projects/libpng/" target=3D"_blank">https://sourcefor=
ge.net/projects/libpng/</a>) seem to be in step; the last change on sourcef=
orge was on 12 February 2023 and the same goes for libpng16 on <a href=3D"h=
ttp://github.com" target=3D"_blank">github.com</a> (<a href=3D"https://gith=
ub.com/glennrp/libpng" target=3D"_blank">https://github.com/glennrp/libpng<=
/a>).=C2=A0 &quot;master&quot; and &quot;tmp/develop&quot; are up-to-date w=
ith libpng16.=C2=A0 I believe &quot;master&quot; and &quot;tmp/develop&quot=
; are identical to libpng16 on github,com; commits 0/0 ahead/behind.</div><=
div><br></div><div>This is the way it should be; the two &quot;master&quot;=
 branches on sourceforge and github should both point to the current major =
release (libpng16).=C2=A0 I never used sourceforge (well, not after the ind=
emnification issue) and all development was done on github; it is likely th=
at from time to time the branches on github pointed to something that was s=
omewhat unstable.=C2=A0 Only tagged revisions are fully tested.=C2=A0 &quot=
;tmp/develop&quot; is new and, I assume, was created to avoid that.</div><d=
iv><br></div><div>I won&#39;t discuss the specific merge request here (disc=
ussions should go in a &quot;pull&quot; request on github) beyond pointing =
out:</div><div><br></div><div><a href=3D"https://github.com/mschlaegl/libpn=
g_rvv-doc" target=3D"_blank">https://github.com/mschlaegl/libpng_rvv-doc</a=
><br></div><div><a href=3D"https://github.com/mschlaegl/libpng_rvv" target=
=3D"_blank">https://github.com/mschlaegl/libpng_rvv</a><br></div><div><a hr=
ef=3D"https://github.com/glennrp/libpng/pull/405" target=3D"_blank">https:/=
/github.com/glennrp/libpng/pull/405</a><br></div><div><br></div><div>Plus o=
bserving that I suspect third party testing of these (mschlaegl) changes (p=
referably synced up to date with glennrp/libpng16) would certainly help val=
idate them.</div><div><br></div></div></div>
_______________________________________________<br>
png-mng-implement mailing list<br>
<a href=3D"mailto:png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" target=3D"_blank=
">png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/png-mng-implement" =
rel=3D"noreferrer" target=3D"_blank">https://lists.sourceforge.net/lists/li=
stinfo/png-mng-implement</a><br>
</blockquote></div>

--00000000000092279805fd26327c--


--===============1865482787639274329==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============1865482787639274329==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
png-mng-implement mailing list
png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

--===============1865482787639274329==--