Re: CALL for DISCUSSION: eXIf 20170115
Glenn Randers-Pehrson <[email protected]>
| Newsgroups | gmane.comp.graphics.png.general |
|---|---|
| Message-ID | <CA+PdXcvVSw0Ep72ZRyOZRcbDQ2L_pXo=re9r2Ues5Ct-DGX09g@mail.gmail.com> |
On Tue, Jan 24, 2017 at 11:15 PM, John Bowler < [email protected]> wrote: > On Tue, Jan 24, 2017 at 7:13 PM, Glenn Randers-Pehrson > <[email protected]> wrote: > > I am "totally set" on responding to your challenge, "show me the > > code", and presenting proof-of-concept for the vote. > > Good, let's do that. You have my code to criticize, I have yours: > > http://www.simplesystems.org/users/glennrp/eXIf/zxif_GM1. > 4snapshot-20170107.diff > > One immediate criticism, that anyone who is still reading what I am > saying will appreciate, search that patch for the string "500000" (no > quotes), you will find: > > + /* Zlib compressed */ > + > + unsigned char temp[500000]; > + > + int inflated_size; > + > + png_free(ping,profile); > + > + s=chunk->data; > + s++; // skip compression byte > + > + /* uncompress chunk->data to temporary profile */ > + inflated_size=exif_inf(s,temp,chunk->size-1); > > ROTFL > > -- > John Bowler <[email protected]> > +1 (541) 450-9885 > PO BOX 3151 > KERBY OR 97531-3151 > USA > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > png-mng-misc mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/png-mng-misc > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ png-mng-misc mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/png-mng-misc