Re: printing from command line patch

Hello!

Thank you! Commited your patch (although tested it only very briefly).

Remarks:
- Try to avoid '//' C++ style comments. Although most GCC-s seem to
  have no problems with those, AFAIK they are not allowed in ANSI C
- I removed setting SPRepr properties in PrintPS::setup_file - it
  is needed primarily to keep user selection across sessions, and we
  do not need such thing for command line.
- DPI only does have effect for bitmap-mode printing.
- I think there is little need for Gnome/KDE command line printing
  frontends for now. What is needed more, is a way to select
  bimap-mode printing and DPI.

Keep up good work!
Lauris Kaplinski

Emile Snyder kirjutas E, 26.01.2004 kell 20:08:
> Hi,
> 
> If you get a chance, please look over the attached patch to enable
> printing from the command line using the ps print module.  It's against
> the CVS HEAD version of sodipodi as of the morning of Jan. 25.  Printing
> to a file (sodipodi --print=">foo.ps" foo.svg), a pipe (sodipodi
> --print="| cat > foo.ps" foo.svg) and a printer (sodipodi --print=lpr
> foo.svg) work for me with no errors or warnings.
> 
> Some confusions:
> * I can't seem to print to a file from the gui using the unmodified CVS
> code.  The file is created, but viewing it in gv shows an empty page. 
> (Tried with various of the lab hazard sign clip art.)
> 
> * Changing the dpi doesn't seem to do anything.  I have 300 dpi hard
> coded in the modules/ps.c::setup_file() function, and changing to to
> other values seemed to have no effect.
> 
> * Should I have made similar modifications to the other print systems
> (gnome, kde, ...?)  If so, what determines which system is being used
> when it's called from the command line?
> 
> Thanks for writing sodipodi!
> -emile
> 
> On Wed, 2004-01-21 at 13:44, Lauris Kaplinski wrote:
> > Hello!
> > 
> > Yes, unfotunately print-to-file got out of sync while moving printing
> > to module.
> > To enable it properly, ::setup_file or some similar method should
> > be added to SPModulePrint, that sets printing module up to send
> > output to file.
> > Modules have also to be set up in main_console. It may require minor
> > tweaking to work proiperly.
> > 
> > I'll try to look into it before next release.
> > 
> > Best wishes,
> > Lauris Kaplinski
> 
> 



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn