problems building on NetBSD
Ty Sarna <[email protected]>
| Newsgroups | gmane.comp.handhelds.matchbox |
|---|---|
| Message-ID | <[email protected]> |
I'm updating my NetBSD package to 0.8.1, and have so far run into the
following issues:
1) mb-applet-menu-launcher uses SIGRTMIN where it doesn't need to.
This signal is related to DNOTIFY, but not all uses are protected by
ifdef, and one of the uses is totally pointless (button_callback()
builds a sigset_t with that signal set, but never uses it!)
--- matchbox-panel-0.8.1/applets/mb-applet-menu-launcher.c.orig 2004-04-09 10:54:14.000000000 -0400
+++ matchbox-panel-0.8.1/applets/mb-applet-menu-launcher.c 2004-04-09 11:15:22.000000000 -0400
@@ -709,18 +709,13 @@
button_callback (MBTrayApp *app, int x, int y, Bool is_released )
{
int abs_x, abs_y;
- sigset_t block_sigset;
static Bool next_cancels;
app_data->button_is_down = True;
if (is_released) app_data->button_is_down = False;
- sigemptyset(&block_sigset);
- sigaddset(&block_sigset, SIGRTMIN);
-
if (is_released && !next_cancels)
{
- sigaddset(&block_sigset, SIGRTMIN);
menu_get_popup_pos (app, &abs_x, &abs_y);
mb_menu_activate (app_data->mbmenu, abs_x, abs_y);
@@ -816,18 +811,24 @@
if (ev->xclient.message_type == app_data->mbcommand_atom
&& ev->xclient.data.l[0] == MB_CMD_SHOW_EXT_MENU )
{
+#ifdef USE_DNOTIFY
sigemptyset(&block_sigset);
sigaddset(&block_sigset, SIGRTMIN);
+#endif
if (!mb_menu_is_active(app_data->mbmenu))
{
int abs_x, abs_y;
+#ifdef USE_DNOTIFY
sigprocmask(SIG_BLOCK, &block_sigset, NULL);
+#endif
menu_get_popup_pos (app, &abs_x, &abs_y);
mb_menu_activate(app_data->mbmenu, abs_x, abs_y);
} else {
mb_menu_deactivate(app_data->mbmenu);
+#ifdef USE_DNOTIFY
sigprocmask(SIG_UNBLOCK, &block_sigset, NULL);
+#endif
}
}
}
2) mb-applet-wireless is linux-specific. There should be a way to
disable it, or configure should do so automatically.
3) matchbox-desktop's makefile unconditionally uses -ldl, which isn't
appropriate everywhere
4) matchbox-window-manager/data/schemas/Makefile doesn't support
install-data-local, but the makefile in the parent directory calls it
with that (not sure why everyone doesn't see this problem? maybe because
of not using gconf?)