Re: misc notes...(and a patch)

on Fri, Oct 04, 2002 at 10:20:21PM -0400, Greg Alexander wrote:
> 
> Okay so I finally figured out how to use this move feature
> to drag the icons around in the taskbar and I have to say I can
> totally see why someone would think that's neat so I can see if I'm
> going to make the mbdock that I really want I'm going to have to fork
> it :)  And if I'm gonna do that then i think I'm gonna do some
> horribly unclean and presumably unpopular things like integrate my
> wierd button bar idea into the dock so I don't need to figure out how
> to get the dock to have multiple rows of docked apps cleanly, etc.
>

You dont have to fork anything ! Just write your own dock/tray -
matchbox will happily work with 'other' docks .. and if you follow
the terms of the GPL your free to use existing mbdock code. 

> 
> Today's patch is for src/wm.c.  When generating a window with a
> transient setting it calls dialog_client_new(), but since my window is
> of type _..._SPLASH, a dialog_client_new() call was already completed,
> so we just waste an allocation.  More importantly for my purposes,
> with type SPLASH the title bar is disabled, but on the newly-created
> dialog_client_new, the hidden title bar flag is not present (the
> client structure that has the flag set is replaced with the one made
> from scratch).  The patch is to only call dialog_client_new() if a
> client was not already created (I guess this could cause wierdness if
> you use a non-dialog type when creating a transient window, but I
> don't think this is a big worry).  Otherwise it just updates the
> 'trans' structure member.
> 

Should a window of type Splash be transient ? 

But this patch does save a possible needless allocation, so I'll add
it. 

Many thanks;

  -- Matthew