Re: [PATCH] fix bad XML output when using todo recurrence

Paul Eggleton <bluelightning <at> bluelightning.org> writes:

> On Friday 05 January 2007 13:33, Erik Hovland wrote:
> > Think you could:
> > A) Rebase the patch against the top opie directory? Like
> >    cvs diff -u libopie2/opiepim/backend/otodoaccessxml.cpp
> 
> Sorry about that. I guess I should do this for all of the other patches that 
> haven't already gone in?

You should. And if there is any formatting change in the patch, take it out. It
is far more useful to have just the fix.

If you want to change format, send a follow up patch.

> > B) Take out anything that is for style/format so that it is just the fix?
> >
> > I would be very appreciative. If I have it right the only real change was
> > on line 580. Is that true?
> 
> Actually, spacing in the XML output was the whole problem - 
> recurrence.toString() (libopie2/opiepim/core/opimrecurrence.cpp line 561) 
> assumes pre-spacing and not post-spacing - it usually returns at line 
> opimrecurrence.cpp line 581. I took the decision to change this function to 
> match a similar function in odatebookaccessxml.cpp that also calls 
> recurrence.toString(). 
> 
> We could just do a one-line fix if you'd prefer, but I think this is better 
> for consistency.

Well, I definitely see your point. But if you want to get to just the fix, I
would have submitted two patches.

But don't listen to my ravings. Keep working! Your fixes are solid. I just want
to make sure I understand them before I commit them.

E

--
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________

http://opie.handhelds.org/cgi-bin/moin.cgi/DeveloperWikiIndex

Opie-devel mailing list
[email protected]
https://handhelds.org/mailman/listinfo/opie-devel