[PATCH] Clock: alarm dialog improvements
Paul Eggleton <[email protected]> Tue, 9 Jan 2007 01:27:48 +1300
| Newsgroups | gmane.comp.handhelds.opie.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi there, The attached patch makes several improvements to the clock alarm dialog: 1) Increases the font size (addresses bug #1597 - http://opie-bugs.oszine.de/view.php?id=1597 ) 2) Improves the usability of the snooze function (addresses bug #1598 - http://opie-bugs.oszine.de/view.php?id=1598 ) 3) Fixes stretched icon (addresses bug #1616 - http://opie-bugs.oszine.de/view.php?id=1616 ) Cheers, Paul _______________________________________________ http://opie.handhelds.org/cgi-bin/moin.cgi/DeveloperWikiIndex Opie-devel mailing list [email protected] https://handhelds.org/mailman/listinfo/opie-devel
clock_alarmdlg.patch
(text/x-diff, 22.6 KB)
Index: noncore/tools/clock/alarmdlgbase.ui
===================================================================
RCS file: /cvs/opie/noncore/tools/clock/alarmdlgbase.ui,v
retrieving revision 1.1.1.1
diff -u -B -b -r1.1.1.1 alarmdlgbase.ui
--- noncore/tools/clock/alarmdlgbase.ui 3 Apr 2004 18:20:07 -0000 1.1.1.1
+++ noncore/tools/clock/alarmdlgbase.ui 8 Jan 2007 12:17:44 -0000
@@ -11,11 +11,17 @@
<rect>
<x>0</x>
<y>0</y>
- <width>124</width>
- <height>92</height>
+ <width>203</width>
+ <height>243</height>
</rect>
</property>
<property stdset="1">
+ <name>font</name>
+ <font>
+ <pointsize>16</pointsize>
+ </font>
+ </property>
+ <property stdset="1">
<name>caption</name>
<string>Form1</string>
</property>
@@ -25,7 +31,7 @@
<vbox>
<property stdset="1">
<name>margin</name>
- <number>6</number>
+ <number>11</number>
</property>
<property stdset="1">
<name>spacing</name>
@@ -54,7 +60,7 @@
</property>
<property stdset="1">
<name>scaledContents</name>
- <bool>true</bool>
+ <bool>false</bool>
</property>
</widget>
<spacer>
@@ -88,6 +94,10 @@
<name>text</name>
<string>TextLabel1</string>
</property>
+ <property stdset="1">
+ <name>scaledContents</name>
+ <bool>false</bool>
+ </property>
</widget>
</hbox>
</widget>
@@ -124,6 +134,10 @@
<cstring>snoozeTime</cstring>
</property>
<property stdset="1">
+ <name>caption</name>
+ <string></string>
+ </property>
+ <property stdset="1">
<name>suffix</name>
<string> mins</string>
</property>
@@ -135,6 +149,13 @@
<name>lineStep</name>
<number>5</number>
</property>
+ <property stdset="1">
+ <name>value</name>
+ <number>5</number>
+ </property>
+ <property>
+ <name>layoutMargin</name>
+ </property>
</widget>
</hbox>
</widget>
@@ -142,9 +163,476 @@
<class>QPushButton</class>
<property stdset="1">
<name>name</name>
+ <cstring>cmdSnooze</cstring>
+ </property>
+ <property stdset="1">
+ <name>minimumSize</name>
+ <size>
+ <width>0</width>
+ <height>100</height>
+ </size>
+ </property>
+ <property stdset="1">
+ <name>palette</name>
+ <palette>
+ <active>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>191</green>
+ <blue>191</blue>
+ </color>
+ <color>
+ <red>127</red>
+ <green>64</green>
+ <blue>64</blue>
+ </color>
+ <color>
+ <red>170</red>
+ <green>85</green>
+ <blue>85</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </active>
+ <disabled>
+ <color>
+ <red>128</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>166</green>
+ <blue>166</blue>
+ </color>
+ <color>
+ <red>127</red>
+ <green>64</green>
+ <blue>64</blue>
+ </color>
+ <color>
+ <red>170</red>
+ <green>85</green>
+ <blue>85</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>128</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </disabled>
+ <inactive>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>166</green>
+ <blue>166</blue>
+ </color>
+ <color>
+ <red>127</red>
+ <green>64</green>
+ <blue>64</blue>
+ </color>
+ <color>
+ <red>170</red>
+ <green>85</green>
+ <blue>85</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </inactive>
+ </palette>
+ </property>
+ <property stdset="1">
+ <name>text</name>
+ <string>Snooze</string>
+ </property>
+ </widget>
+ <widget>
+ <class>QPushButton</class>
+ <property stdset="1">
+ <name>name</name>
<cstring>cmdOk</cstring>
</property>
<property stdset="1">
+ <name>minimumSize</name>
+ <size>
+ <width>0</width>
+ <height>32</height>
+ </size>
+ </property>
+ <property stdset="1">
+ <name>palette</name>
+ <palette>
+ <active>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>192</red>
+ <green>255</green>
+ <blue>192</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>223</red>
+ <green>255</green>
+ <blue>223</blue>
+ </color>
+ <color>
+ <red>96</red>
+ <green>127</green>
+ <blue>96</blue>
+ </color>
+ <color>
+ <red>128</red>
+ <green>170</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </active>
+ <disabled>
+ <color>
+ <red>128</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>192</red>
+ <green>255</green>
+ <blue>192</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>230</red>
+ <green>255</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>96</red>
+ <green>127</green>
+ <blue>96</blue>
+ </color>
+ <color>
+ <red>128</red>
+ <green>170</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>128</red>
+ <green>128</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </disabled>
+ <inactive>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>192</red>
+ <green>255</green>
+ <blue>192</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>230</red>
+ <green>255</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>96</red>
+ <green>127</green>
+ <blue>96</blue>
+ </color>
+ <color>
+ <red>128</red>
+ <green>170</green>
+ <blue>128</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>255</green>
+ <blue>255</blue>
+ </color>
+ <color>
+ <red>238</red>
+ <green>238</green>
+ <blue>230</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ <color>
+ <red>255</red>
+ <green>221</green>
+ <blue>118</blue>
+ </color>
+ <color>
+ <red>0</red>
+ <green>0</green>
+ <blue>0</blue>
+ </color>
+ </inactive>
+ </palette>
+ </property>
+ <property stdset="1">
<name>text</name>
<string>Close</string>
</property>
Index: noncore/tools/clock/clock.cpp
===================================================================
RCS file: /cvs/opie/noncore/tools/clock/clock.cpp,v
retrieving revision 1.30
diff -u -B -b -r1.30 clock.cpp
--- noncore/tools/clock/clock.cpp 23 May 2005 23:47:35 -0000 1.30
+++ noncore/tools/clock/clock.cpp 8 Jan 2007 12:17:46 -0000
@@ -106,9 +106,8 @@
pixmap->setPixmap( Opie::Core::OResource::loadPixmap("clock/alarmbell") );
alarmDlgLabel->setText(txt);
- connect(snoozeTime, SIGNAL(valueChanged(int)), this,
- SLOT(changePrompt(int)));
- connect(cmdOk, SIGNAL(clicked()), this, SLOT(checkSnooze()));
+ connect(cmdSnooze, SIGNAL(clicked()), this, SLOT(checkSnooze()));
+ connect(cmdOk, SIGNAL(clicked()), this, SLOT(accept()));
}
//
@@ -144,14 +143,6 @@
-void
-AlarmDlg::changePrompt(int mins)
-{
- cmdOk->setText(mins > 0 ? tr("Snooze") : tr("Close") );
-}
-
-
-
Clock::Clock( QWidget * parent, const char *, WFlags f )
: ClockBase( parent, "clock", f ), swatch_splitms(99), init(FALSE) // No tr
{
Index: noncore/tools/clock/clock.h
===================================================================
RCS file: /cvs/opie/noncore/tools/clock/clock.h,v
retrieving revision 1.13
diff -u -B -b -r1.13 clock.h
--- noncore/tools/clock/clock.h 3 Apr 2004 20:10:15 -0000 1.13
+++ noncore/tools/clock/clock.h 8 Jan 2007 12:17:46 -0000
@@ -44,7 +44,6 @@
private slots:
void checkSnooze(void);
- void changePrompt(int minutes);
};
class Clock : public ClockBase