Re: [PATCH] opie-multikey: Rename config dialog buttons to be more clear

On Fri, Jan 12, 2007 at 08:11:52PM +0200, Paul Sokolovsky wrote:
> Hello Erik,
> 
> Friday, January 12, 2007, 8:04:57 PM, you wrote:
> 
> > On Thu, Jan 11, 2007 at 11:42:24PM +0200, Paul Sokolovsky wrote:
> >> opie-multikey: Rename buttons to add/remove custom keymap to be more clear.
> >> * opie-multikey needs usability improvements at all - it may take a user
> >> some effort to figure out that to change language layout, one needs to call
> >> config (which lives on a key marked as shift), select language, and tap
> >> OK at window top. Most people would tap "Add" and present with file selection
> >> dialog with unknown to them purpose. So, at lease name buttons "Add custom..."
> >> and "Remove custom", to correspond to their functions.
> 
> > I have attached a patch which shows what I think keeps the spirit of
> > your patch. It changes the button to say 'Add keymap' and 'Remove
> > keymap'. It also hides the remove button until a custom keymap has been
> > selected. This should help the friendliness of the dialogue.
> 
>   Looks good. I'd still however draw attention to using "..." suffix
> for widget labels which don't perform action, but open another
> dialogs. It's not my/wince whim - it's convention started not even in
> Mackintoshes, but in generic UI guidelines used even for Text UI
> toolkits. And OPIE itself uses it - unfortunately, inconsistently.

I put "..." on the add button so it says "Add keymap...". Let me know if
you want something different. Otherwise, my mods on your patch have been
applied.

E

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request
_______________________________________________

http://opie.handhelds.org/cgi-bin/moin.cgi/DeveloperWikiIndex

Opie-devel mailing list
[email protected]
https://handhelds.org/mailman/listinfo/opie-devel