Re: [Fwd: Re: Another 1.2.3 candidate bug - #1838]
Erik Hovland <[email protected]> Mon, 12 Feb 2007 16:13:06 -0800
| Newsgroups | gmane.comp.handhelds.opie.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Feb 13, 2007 at 12:38:46AM +0100, Rene Wagner wrote: > On Mon, 2007-02-12 at 13:21 -0800, Erik Hovland wrote: > > On Tue, Feb 13, 2007 at 12:06:07AM +0300, Dmitriy Korovkin wrote: > > > Erik, > > > While this is a good idea, but the patch actually must be accompanied by > > > the other one that allows setting up these parameters in the OPIE > > > Bluetooth Manager. Before the second part of the work has not been done, > > > this patch IMHO, should not be applied. > > > > Are you telling me that the 'other one' does not yet exist. So the > > feature is incomplete. This patch should work for any familiar supported > > handheld. And familiar already sets up the sysconfig file for the > > graphical environment. > > I think Dmitriy's point is that there are two places in Opie that > handle this sort of thing, one is the bluetooth applet, the other > is the bluetooth manager. > > The patch only covers the bluetooth applet. To keep things consistent > a similar patch would be required for the bluetooth manager, or > (preferrably) the code in question would need to be factored out into > a tiny lib to be used by both applications. I can appreciate this. What tree of 'bluetooth manager' code are you guys talking about? noncore/net/opietooth/manager noncore/settings/networksettings2/bluetooth I am assuming the former. If so, that code has no discovery code associated to handheld bluetooth devices. So it needs a whole feature. Not just the addition of this functionality. The later seems like code to setup connections after bluetooth devices have been discovered. I understand your point, I don't see the importance of making noncore/net/opietooth/manager peer with the applet. Help me understand. E -- Erik Hovland mail: [email protected] web: http://hovland.org/ PGP/GPG public key available on request _______________________________________________ http://opie.handhelds.org/cgi-bin/moin.cgi/DeveloperWikiIndex Opie-devel mailing list [email protected] https://handhelds.org/mailman/listinfo/opie-devel