Re: [PATCH] 2.6.5-mm6 for simpad

Am Fr, den 16.04.2004 schrieb Bernhard Rosenkraenzer um 21:08:
> I've ported the patches for 2.6.0-test3 to a more recent kernel (2.6.5-mm6) 
> and added a couple of patches of my own.
> The patch can be found at
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/bero/2.6/simpad/
> 
> The current state is "It compiles, therefore it works"(tm); I haven't tested 
> it yet (got to find that *****ing cable ;) ).

While very much appreciating that work, I have some problems with that
patch:

At first, it is _HUGE_. How are we supposed to try getting stuff
upstream when it is not clearly separated. At least a separation of the
SIMpad specifics would be very much needed.

The next thing is about correctness, i.e. I spotted the first mistake
in the first 10 lines of the patch. To head-sa1100.S you add
stuff which has been already merged. After all this is kernel code, so
we should really be very careful here.

I had a terrible weekend and couldn't test the kernel. Did anyone?

Best regards,
-- 
:M:
--------------------------------------------------------------------------
Dipl.-Inf. Michael 'Mickey' Lauer   [email protected] 
  Raum 10b - ++49 69 798 28358       Fachbereich Informatik und Biologie  
--------------------------------------------------------------------------



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click