Re: lirc_atiusb (X10 remote) Kernel driver

Michael Markstaller via LIRC-list <[email protected]> Fri, 25 Aug 2017 12:57:12 +0200

Newsgroups	gmane.comp.hardware.lirc
Message-ID	<[email protected]>

Got a little further; with the attached patch I was at least able to
compile lirc_atiusb.ko using:
Ubuntu xenial lirc source-package (lircd 0.9.0) Kernel 4.4.0-53-generic

Still asking myself: how does this fit into recent lirc, I somewhat
dislike the idea to operate with old versions and strange patches before
understanding where lirc_atiusb should really be and moving onto the
target-plattform LEDE where things get nastier with cross-compiling..

Michael

Am 24.08.2017 um 13:59 schrieb Michael Markstaller:
> Hi,
> 
> a generic question: whats the status of the lirc_atiusb kernel driver?
> (Not atilibusb - I need channels, 1-16)
> 
> Last compiled this successful back in Aug 2010 with 2.6.32 and lirc
> 0.8.5 it works 100% since then, so I didnt bother. But the hardware is
> slowly dying..
> Though I *really* still like the X10 remote for every room and they are
> still available somehow..
> 
> Anyway, as I failed miserable to compile it under Ubuntu 16.04, 16.10
> (x86, amd64) during the last two days, ...
> (target platform is rather LEDE/MIPS, but failing under stock-Ubuntu
> with pkg-source and master/trunk tells me: this takes be some more
> debugging and hacking)
> 
> Without details for now, before digging deeper:
> -> Anybody using it, tested it recently?
> 
> P.S.: this is one of the nasty things about software that "just works":
> you don't hear a single word for many years - because it simply just
> works :)
> 
> 
> best regards
> 
> Michael
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

lirc-090-ubuntu.patch (text/x-patch, 2.1 KB)

--- drivers/lirc_dev/lirc_dev.c.org	2017-08-25 11:47:19.058563230 +0200
+++ drivers/lirc_dev/lirc_dev.c	2017-08-25 11:50:22.062131639 +0200
@@ -620,7 +620,7 @@
 
 unsigned int lirc_dev_fop_poll(struct file *file, poll_table *wait)
 {
-	struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];
+	struct irctl *ir = irctls[iminor(file->f_path.dentry->d_inode)];
 	unsigned int ret;
 
 	if (!ir) {
@@ -666,7 +666,7 @@
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 35)
 	struct irctl *ir = irctls[iminor(inode)];
 #else
-	struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];
+	struct irctl *ir = irctls[iminor(file->f_path.dentry->d_inode)];
 #endif
 	if (!ir) {
 		printk(KERN_ERR "lirc_dev: %s: no irctl found!\n", __func__);
@@ -751,7 +751,7 @@
 			  size_t length,
 			  loff_t *ppos)
 {
-	struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];
+	struct irctl *ir = irctls[iminor(file->f_path.dentry->d_inode)];
 	unsigned char *buf;
 	int ret = 0, written = 0;
 	DECLARE_WAITQUEUE(wait, current);
@@ -852,10 +852,10 @@
 {
 	void *data = NULL;
 
-	if (file && file->f_dentry && file->f_dentry->d_inode &&
-	    file->f_dentry->d_inode->i_rdev) {
+	if (file && file->f_path.dentry && file->f_path.dentry->d_inode &&
+	    file->f_path.dentry->d_inode->i_rdev) {
 		struct irctl *ir;
-		ir = irctls[iminor(file->f_dentry->d_inode)];
+		ir = irctls[iminor(file->f_path.dentry->d_inode)];
 		data = ir->d.data;
 	}
 
@@ -867,7 +867,7 @@
 ssize_t lirc_dev_fop_write(struct file *file, const char *buffer,
 			   size_t length, loff_t *ppos)
 {
-	struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];
+	struct irctl *ir = irctls[iminor(file->f_path.dentry->d_inode)];
 
 	if (!ir) {
 		printk(KERN_ERR "%s: called with invalid irctl\n", __func__);
--- drivers/lirc_atiusb/lirc_atiusb.c.org	2017-08-25 11:54:38.691111771 +0200
+++ drivers/lirc_atiusb/lirc_atiusb.c	2017-08-25 11:55:19.459902443 +0200
@@ -48,7 +48,7 @@
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/kmod.h>
-#include <linux/smp_lock.h>
+// #include <linux/smp_lock.h>
 #include <linux/completion.h>
 #include <linux/uaccess.h>
 #include <linux/usb.h>

signature.asc (application/pgp-signature, 819 B)