Re: [PATCH 2/2] configure.ac: consistently require the same Python version

Doron Behar <[email protected]> Thu, 28 May 2026 19:00:00 +0300
Newsgroups gmane.comp.hardware.lirc
Message-ID <ahhlcBELe7ZuZkm-@ZENIX>
On Thu, May 28, 2026 at 01:37:32PM +0200, Thomas Uhle wrote:
> On Thu, 28 May 2026, Doron Behar wrote:
> 
> > [...]
> > 
> > +m4_define([PYTHON_MIN_VERSION], [3.7])
> > # Try the 'm' (malloc/abiflags) version first, fallback to standard python3
> > -PKG_CHECK_MODULES([PYTHON], [python3m >= 3.7], [pkg_cv_python_name="python3m"], [
> > -    PKG_CHECK_MODULES([PYTHON], [python3 >= 3.7], [pkg_cv_python_name="python3"], [
> > -        AC_MSG_WARN([No python package found >= 3.1 (missing devel package?)])
> > +PKG_CHECK_MODULES([PYTHON], [python3m >= [PYTHON_MIN_VERSION,] [pkg_cv_python_name="python3m"], [
> > +    PKG_CHECK_MODULES([PYTHON], [python3 >= [PYTHON_MIN_VERSION,] [pkg_cv_python_name="python3"], [
> > +        AC_MSG_WARN([No python package found >= [PYTHON_MIN_VERSION] (missing devel package?)])
> 
> Looks like mismatched brackets ...  Have you tested these changes?

You were right again - I thought you had a bracket mistake so I wrote
something else there but your original suggestion was perfect (tested it
this time :)).

I sent both of these patches here as upstream seems to accept them
there:

<https://sourceforge.net/p/lirc/tickets/392/>

Doron.