Re: FYI: Bug in ICMP destination unreachable handling fixed
"Coleman Brumley" <[email protected]>
| Newsgroups | gmane.comp.hardware.microcontrollers.ethernut |
|---|---|
| Organization | PolarSoft, Inc. |
| Message-ID | <[email protected]> |
Ole, Can you please post the patch here as well? Coleman > -----Original Message----- > From: en-nut-discussion-bounces-inJ12LbcDfezQB+pC5nmwQ@public.gmane.org [mailto:en-nut-discussion- > [email protected]] On Behalf Of Ole Reinhardt > Sent: Monday, September 28, 2015 7:57 AM > To: Ethernut User Chat (English) <[email protected]> > Subject: [En-Nut-Discussion] FYI: Bug in ICMP destination unreachable > handling fixed > > Hi all, > > in SVN trunk r6135 I fix a bug in the handling of ICMP code 3 messages > (destination unreachable). It was caused by missing parenthesis in pointer > arithmetic. > > As result, NutTcpFindSocket() (in NutIcmpUnreach()) was fed with invalid > data. In worst case this could have led to sockets beeing abborting accidently, > in most cases nothing happened at all, as no matching socket could be found. > > But even worse, this bug also could result in crashes, if the pointer arithmetic > resulted in a read out of the physical memory bounds. > > It might be a good idea to update Nut/OS in your projects which rely on a > correct ICMP handling. > > Best regards, > > Ole > > -- > kernel concepts GmbH Tel: +49-271-771091-14 > Sieghuetter Hauptweg 48 Mob: +49-177-7420433 > D-57072 Siegen > http://www.embedded-it.de > http://www.kernelconcepts.de > _______________________________________________ > http://lists.egnite.de/mailman/listinfo/en-nut-discussion _______________________________________________ http://lists.egnite.de/mailman/listinfo/en-nut-discussion