Re: Re: ansel cli
Chuck Hagenbuch <[email protected]>
| Newsgroups | gmane.comp.horde.ansel |
|---|---|
| Message-ID | <[email protected]> |
Quoting Vijay Mahrra <[email protected]>: > the attached patch You need to attach the patch as text/plain. > moves the function getImageFromFile() from scripts/ansel.php > to lib/Ansel.php Why? > i think i've violated that by moving getImageFromFile() for the sake of not > having code repeated in xppublish :( Eh? xppublish gets data from file uploads, not a local filesystem. > also, being a fan of logging everything verbosely, i was wondering if > it's worth changing the scripts to log all message notifications > (depending of course on the level that is set) All? Probably not. Anything that's an error or a backend query, probably, at a debug level. -chuck -- "Regard my poor demoralized mule!" - Juan Valdez -- ansel mailing list - Join the hunt: http://horde.org/bounties/#ansel Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]